Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies to their latest stable release #15216

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Upgrade dependencies to their latest stable release #15216

merged 2 commits into from
Oct 18, 2022

Conversation

gerolf-da
Copy link
Contributor

@gerolf-da gerolf-da commented Oct 11, 2022 •
edited
Loading

The outdated dependencies where determined by running bazel run @maven//:outdated.

Not all dependencies are brought up to the latest version available on Maven Central, for the following reasons:

Nobody dares to touch DB:
com.oracle.database.jdbc:ojdbc8 [19.14.0.0 -> 21.7.0.0]
com.oracle.database.jdbc.debug:ojdbc8_g [19.14.0.0 -> 21.7.0.0]
com.h2database:h2 [2.1.210 -> 2.1.214]
org.flywaydb:flyway-core [8.4.1 -> 9.4.0]

License issues beyond version 2.6.x:
com.typesafe.akka:akka-actor_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-actor-testkit-typed_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-actor-typed_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-http_2.13 [10.2.8 -> 10.4.0-M1]
com.typesafe.akka:akka-http-spray-json_2.13 [10.2.8 -> 10.4.0-M1]
com.typesafe.akka:akka-http-testkit_2.13 [10.2.8 -> 10.4.0-M1]
com.typesafe.akka:akka-slf4j_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-stream_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-stream-testkit_2.13 [2.6.18 -> 2.7.0-M3]
com.typesafe.akka:akka-testkit_2.13 [2.6.18 -> 2.7.0-M3]

Not a stable release:
com.chuusai:shapeless_2.13 [2.3.3 -> 2.4.0-M1]
io.circe:circe-core_2.13 [0.14.3 -> 0.15.0-M1]
io.circe:circe-generic_2.13 [0.14.3 -> 0.15.0-M1]
io.circe:circe-parser_2.13 [0.14.3 -> 0.15.0-M1]
org.scalameta:munit_2.13 [0.7.29 -> 1.0.0-M6]
org.scalactic:scalactic_2.13 [3.2.14 -> 3.3.0-SNAP3]
org.scalatest:scalatest_2.13 [3.2.14 -> 3.3.0-SNAP3]
org.scalatestplus:scalacheck-1-15_2.13 [3.2.11.0 -> 3.3.0.0-SNAP3]
org.scalatestplus:selenium-3-141_2.13 [3.2.10.0 -> 3.3.0.0-SNAP3]
org.scalatestplus:testng-6-7_2.13 [3.2.10.0 -> 3.3.0.0-SNAP3]
org.tpolecat:doobie-core_2.13 [0.13.4 -> 1.0.0-RC2]
org.tpolecat:doobie-hikari_2.13 [0.13.4 -> 1.0.0-RC2]
org.tpolecat:doobie-postgres_2.13 [0.13.4 -> 1.0.0-RC2]
com.fasterxml.jackson.core:jackson-core [2.13.4 -> 2.14.0-rc2]
com.fasterxml.jackson.core:jackson-databind [2.13.4 -> 2.14.0-rc2]

Netty + boringssl + grpc + protobuf need be kept in sync, and these are
also not stable releases:
io.netty:netty-buffer [4.1.79.Final -> 5.0.0.Alpha2]
io.netty:netty-codec-http2 [4.1.79.Final -> 5.0.0.Alpha2]
io.netty:netty-handler [4.1.79.Final -> 5.0.0.Alpha2]
io.netty:netty-handler-proxy [4.1.79.Final -> 5.0.0.Alpha2]
io.netty:netty-resolver [4.1.79.Final -> 5.0.0.Alpha2]
com.google.protobuf:protobuf-java [3.21.7 -> 4.0.0-rc-2]

Scalaz changed a few annoying things in 7.3, so let's stick to 7.2:
org.scalaz:scalaz-core_2.13 [7.2.34 -> 7.4.0-M12]
org.scalaz:scalaz-scalacheck-binding_2.13 [7.2.34-scalacheck-1.15 -> 7.4.0-M12]
org.scalacheck:scalacheck_2.13 [1.15.4 -> 1.17.0]

Determined by the rules_scala:
org.scala-lang:scala-library [2.13.8 -> 2.13.10]

CHANGELOG_BEGIN
CHANGELOG_END

@gerolf-da gerolf-da requested review from ray-roestenburg-da and a team as code owners October 11, 2022 15:03
@gerolf-da
Copy link
Contributor Author

gerolf-da commented Oct 11, 2022 •
edited
Loading

@mziolekda, @miklos-da, @rgugliel-da, @soren-da: heads up that these dependency updates might be coming your way soon. If you have any concerns, please raise them rather sooner than later.

@rgugliel-da
Copy link
Contributor

@mziolekda, @miklos-da, @rgugliel-da, @soren-da: heads up that these dependency updates might be coming your way soon. If you have any concerns, please raise them rather sooner than later.

Thanks! In such cases, you can drop a message in channel #team-sdk-updates where we discuss bumping Daml SDK in Canton.

nicu-da
nicu-da reviewed Oct 11, 2022
View reviewed changes
bazel-java-deps.bzl Outdated Show resolved Hide resolved
nicu-da
nicu-da reviewed Oct 11, 2022
View reviewed changes
...ant-integration-api/src/test/lib/scala/platform/indexer/ha/IndexerStabilityTestFixture.scala
@@ -94,6 +93,7 @@ object IndexerStabilityTestFixture {
}
)
.acquire()
metrics = new Metrics(new MetricRegistry)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually surprised it wasn't required before actually. Using the same MetricRegistry instance for multiple indexers means that multiple indexers try to register a gauge under the same name (the crash/exception was triggered by InMemoryStateUpdater.scala#97). I did a quick search of what might have changed in Dropwizard Metrics between the two releases, but I would expect it to fail already actually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised why does it even pass though.
I've created this issue for the newly added gauges in dropwizard dropwizard/metrics#2920, but shouldn't this fail as well during indexer restarts? We're recreating the DbDispatcher as part of the restart therefore it would re-create the thread pool associated with it. And the gauge registration was added as part of metric instrumentation for the InstrumentedExecutorService for the ThreadPoolExecutor in this case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer relevant since InstrumentedExecutorService does not use dropwizard anymore.

@gerolf-da
Upgrade dependencies to their latest stable release
d5b24c7 
The outdated dependencies where determined by running
`bazel run @maven//:outdated`.

Not all dependencies are brought up to the latest version available on
Maven Central, for the following reasons:

Nobody dares to touch DB:
  com.oracle.database.jdbc:ojdbc8 [19.14.0.0 -> 21.7.0.0]
  com.oracle.database.jdbc.debug:ojdbc8_g [19.14.0.0 -> 21.7.0.0]
  com.h2database:h2 [2.1.210 -> 2.1.214]
  org.flywaydb:flyway-core [8.4.1 -> 9.4.0]

License issues beyond version 2.6.x:
  com.typesafe.akka:akka-actor_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-actor-testkit-typed_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-actor-typed_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-http_2.13 [10.2.8 -> 10.4.0-M1]
  com.typesafe.akka:akka-http-spray-json_2.13 [10.2.8 -> 10.4.0-M1]
  com.typesafe.akka:akka-http-testkit_2.13 [10.2.8 -> 10.4.0-M1]
  com.typesafe.akka:akka-slf4j_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-stream_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-stream-testkit_2.13 [2.6.18 -> 2.7.0-M3]
  com.typesafe.akka:akka-testkit_2.13 [2.6.18 -> 2.7.0-M3]

Not a stable release:
  com.chuusai:shapeless_2.13 [2.3.3 -> 2.4.0-M1]
  io.circe:circe-core_2.13 [0.14.3 -> 0.15.0-M1]
  io.circe:circe-generic_2.13 [0.14.3 -> 0.15.0-M1]
  io.circe:circe-parser_2.13 [0.14.3 -> 0.15.0-M1]
  org.scalameta:munit_2.13 [0.7.29 -> 1.0.0-M6]
  org.scalactic:scalactic_2.13 [3.2.14 -> 3.3.0-SNAP3]
  org.scalatest:scalatest_2.13 [3.2.14 -> 3.3.0-SNAP3]
  org.scalatestplus:scalacheck-1-15_2.13 [3.2.11.0 -> 3.3.0.0-SNAP3]
  org.scalatestplus:selenium-3-141_2.13 [3.2.10.0 -> 3.3.0.0-SNAP3]
  org.scalatestplus:testng-6-7_2.13 [3.2.10.0 -> 3.3.0.0-SNAP3]
  org.tpolecat:doobie-core_2.13 [0.13.4 -> 1.0.0-RC2]
  org.tpolecat:doobie-hikari_2.13 [0.13.4 -> 1.0.0-RC2]
  org.tpolecat:doobie-postgres_2.13 [0.13.4 -> 1.0.0-RC2]
  com.fasterxml.jackson.core:jackson-core [2.13.4 -> 2.14.0-rc2]
  com.fasterxml.jackson.core:jackson-databind [2.13.4 -> 2.14.0-rc2]

Netty + boringssl + grpc + protobuf need be kept in sync, and these are
also not stable releases:
  io.netty:netty-buffer [4.1.79.Final -> 5.0.0.Alpha2]
  io.netty:netty-codec-http2 [4.1.79.Final -> 5.0.0.Alpha2]
  io.netty:netty-handler [4.1.79.Final -> 5.0.0.Alpha2]
  io.netty:netty-handler-proxy [4.1.79.Final -> 5.0.0.Alpha2]
  io.netty:netty-resolver [4.1.79.Final -> 5.0.0.Alpha2]
  com.google.protobuf:protobuf-java [3.21.7 -> 4.0.0-rc-2]

Scalaz changed a few annoying things in 7.3, so let's stick to 7.2:
  org.scalaz:scalaz-core_2.13 [7.2.34 -> 7.4.0-M12]
  org.scalaz:scalaz-scalacheck-binding_2.13 [7.2.34-scalacheck-1.15 -> 7.4.0-M12]
  org.scalacheck:scalacheck_2.13 [1.15.4 -> 1.17.0]

Determined by the rules_scala:
  org.scala-lang:scala-library [2.13.8 -> 2.13.10]

CHANGELOG_BEGIN
CHANGELOG_END
@gerolf-da gerolf-da force-pushed the gerolf/deps-upgrade branch from cb7987e to d5b24c7 Compare October 17, 2022 08:32
@gerolf-da gerolf-da merged commit 1454497 into main Oct 18, 2022
@gerolf-da gerolf-da deleted the gerolf/deps-upgrade branch October 18, 2022 06:50
tudor-da added a commit that referenced this pull request Oct 21, 2022
@tudor-da
Revert "Upgrade dependencies to their latest stable release (#15216)"
4c10730 
This reverts commit 1454497

changelog_begin
changelog_end
tudor-da added a commit that referenced this pull request Oct 24, 2022
@tudor-da
Revert "Upgrade dependencies to their latest stable release (#15216)" (…
1a4ef5b 
…#15309)

This reverts commit 1454497

changelog_begin
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atriantafyllos-da atriantafyllos-da atriantafyllos-da left review comments

@nicu-da nicu-da nicu-da left review comments

@tudor-da tudor-da tudor-da approved these changes

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@ray-roestenburg-da ray-roestenburg-da Awaiting requested review from ray-roestenburg-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gerolf-da @rgugliel-da @garyverhaegen-da @tudor-da @nicu-da @atriantafyllos-da