Remove reliance on implicit party allocation in CI tests [DPP-1234] #15037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mziolekda
force-pushed
the
mziolek/remove-implicit-party-creation
branch
from
c7ce674 to
d9e6b07
Compare
mziolekda
requested review from
ray-roestenburg-da,
S11001001,
a team and
remyhaemmerle-da
as code owners
skisel-da
reviewed
Sep 20, 2022
daml-script/test/src/com/digitalasset/daml/lf/engine/script/test/JsonApiIt.scala
Outdated
Show resolved
Hide resolved
skisel-da
reviewed
Sep 20, 2022
...upport/scala/codegen-sample-app/src/test/scala/com/digitalasset/codegen/ScalaCodeGenIT.scala
Show resolved
Hide resolved
skisel-da
reviewed
Sep 20, 2022
ledger-service/http-json/src/itlib/scala/http/AbstractHttpServiceIntegrationTest.scala
Outdated
Show resolved
Hide resolved
skisel-da
reviewed
Sep 20, 2022
ledger-service/http-json/src/itlib/scala/http/AbstractHttpServiceIntegrationTestFuns.scala
Outdated
Show resolved
Hide resolved
skisel-da
reviewed
Sep 20, 2022
ledger/sandbox-on-x/src/test/lib/scala/com/daml/platform/sandbox/fixture/CreatesParties.scala
Show resolved
Hide resolved
skisel-da
reviewed
Sep 20, 2022
ledger/sandbox-on-x/src/test/lib/scala/com/daml/platform/sandbox/fixture/CreatesParties.scala
Show resolved
Hide resolved
remyhaemmerle-da
approved these changes
Sep 20, 2022
mziolekda
requested review from
nickchapman-da,
basvangijzel-DA,
akrmn and
dylant-da
as code owners
mziolekda
force-pushed
the
mziolek/remove-implicit-party-creation
branch
from
e5236a7 to
0f46feb
Compare
skisel-da
reviewed
Sep 21, 2022
daml-script/test/src/com/digitalasset/daml/lf/engine/script/test/JsonApiIt.scala
Outdated
Show resolved
Hide resolved
skisel-da
reviewed
Sep 21, 2022
daml-script/test/src/com/digitalasset/daml/lf/engine/script/test/JsonApiIt.scala
Outdated
Show resolved
Hide resolved
…s of the sandbox-on-x CHANGELOG_BEGIN CHANGELOG_END
mziolekda
force-pushed
the
mziolek/remove-implicit-party-creation
branch
from
de37a96 to
7d06416
Compare
skisel-da
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicit party allocation has been removed from our commercial offering a while back. It has found its way, however into our testing. There we were still able to rely on the sandbox-on-x (our test ledger) that kept on the support for this obsolete functionality. Following component tests have been found to be affected:
CHANGELOG_BEGIN
CHANGELOG_END