rename interface library to api-type-signature; alias symbols #14783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S11001001
added
component/daml-lf
CHANGELOG_BEGIN - [Scala API] The "quasi-public" API in ``com.daml.lf.iface`` has moved to the new ``com.daml.lf.typesig`` package, with many accompanying name changes as documented in `issue #13669 <https://github.com/digital-asset/daml/issues/13669>`__. Daml 2.5.0 or later will remove the old names, and also rename the Maven artifact from ``daml-lf-interface`` to ``daml-lf-api-type-signature``. We recommend that users of this API use the deprecation guidance in 2.4.0 to port their applications before this happens. CHANGELOG_END
5 tasks
S11001001
requested review from
ray-roestenburg-da,
remyhaemmerle-da and
garyverhaegen-da
as code owners
2 tasks
ray-roestenburg-da
approved these changes
Aug 23, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stephencompall-DA
pushed a commit
that referenced
this pull request
Aug 29, 2022
CHANGELOG_BEGIN - [Scala API] ``com.daml.lf.iface`` has been deprecated, as discussed further in `issue #14783 <https://github.com/digital-asset/daml/pull/14783>`__. Use the deprecation warnings as guidance to the new names. CHANGELOG_END
S11001001
added a commit
that referenced
this pull request
Aug 29, 2022
* new names in daml-script/runner * new names in json-api * new names in Scala bindings/codegen * new names in Java bindings/codegen * new names in daml-lf interpreter tests * more new names in daml-script tests * new names in navigator backend * deprecate all iface symbols and old method names CHANGELOG_BEGIN - [Scala API] ``com.daml.lf.iface`` has been deprecated, as discussed further in `issue #14783 <https://github.com/digital-asset/daml/pull/14783>`__. Use the deprecation warnings as guidance to the new names. CHANGELOG_END * prefix cases in OrderingSpec - suggested by @remyhaemmerle-da; thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The renaming part of #13669, without the deprecations. The Maven target also doesn't change name yet.