Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF: distinguish template Id from interface Id in exercise command #14755

Merged
merged 3 commits into from
Aug 19, 2022

Conversation

remyhaemmerle-da
Copy link
Collaborator

preliminary work for #14747

CHANGELOG_BEGIN
CHANGELOG_END

@remyhaemmerle-da remyhaemmerle-da marked this pull request as ready for review August 18, 2022 17:32
@remyhaemmerle-da remyhaemmerle-da requested review from a team and S11001001 as code owners August 18, 2022 17:32
@remyhaemmerle-da remyhaemmerle-da requested a review from a team August 18, 2022 17:32
Comment on lines +89 to +90
// In order to split the issue in several PRs, we allow abusing the templateId case as an interface.
// We will change once we have added the interface_id field to the legder API Exercise command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the comment

Copy link
Contributor

@akrmn akrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@remyhaemmerle-da remyhaemmerle-da merged commit 48abfeb into main Aug 19, 2022
@remyhaemmerle-da remyhaemmerle-da deleted the remy-lf-exe-cmd branch August 19, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants