Change placeholder unit viewtypes to empty records #14656
Conversation
dylant-da
force-pushed
the
non-unit-viewtypes
branch
from
006e7dd to
9795f46
Compare
CHANGELOG_BEGIN CHANGELOG_END
dylant-da
requested review from
stefanobaghino-da,
a team,
hrischuk-da,
ray-roestenburg-da,
garyverhaegen-da,
S11001001,
remyhaemmerle-da and
akrmn
as code owners
dylant-da
removed request for
a team,
S11001001,
stefanobaghino-da,
garyverhaegen-da and
hrischuk-da
dylant-da
requested review from
cocreature
and removed request for
ray-roestenburg-da
| @@ -7,9 +7,11 @@ module Interface where | |||
|
|
|||
| import DA.Assert ((===)) | |||
|
|
|||
| data EmptyInterfaceView = EmptyInterfaceView | |||
There was a problem hiding this comment.
This declares an enum, not a record, so it should be
| data EmptyInterfaceView = EmptyInterfaceView | |
| data EmptyInterfaceView = EmptyInterfaceView {} |
You can tell because the desugared version of this declaration has the "stupid theta" GHC.Types.DamlEnum:
data GHC.Types.DamlEnum => EmptyInterfaceView = EmptyInterfaceViewTangentially, I had a vague memory of the compiler failing with data declarations like this one, suggesting to make it explicitly a record with empty braces or explicitly a variant with empty parens. The docs do mention this restriction, but I wasn't able to replicate it even with sdk-version: 1.14.0 - turns out this restriction was removed in 0.13.33 (2019-11-06)
There was a problem hiding this comment.
Digging a bit more, that is the reason for the GHC.Types.DamlEnum stupid theta: it's only used for single-constructor enums to differentiate them from variants and records, while enums with more constructors don't need it, see #3345
There was a problem hiding this comment.
Replaced all using sed -i 's/data EmptyInterfaceView = EmptyInterfaceView/data EmptyInterfaceView = EmptyInterfaceView {}/' $(ag 'data EmptyInterfaceView = EmptyInterfaceView' -l), fingers crossed
There was a problem hiding this comment.
I approve the idea behind this PR but to meet the requirement that an interface viewtype must be a record you will need to change the EmptyInterfaceView data declarations to make them explicitly records, otherwise the compiler will treat them as enums.
Hopefully it should be enough to search and replace s/(data EmptyInterfaceView = EmptyInterfaceView)/$1 {}/ and then refresh the golden files.
fingers crossed! |
dylant-da
force-pushed
the
non-unit-viewtypes
branch
from
7c78953 to
01252a2
Compare
No description provided.