Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ghc-repo-override flag to override GHC used in daml-sdk-head build #14238

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add --ghc-repo-override flag to override GHC used in daml-sdk-head build #14238

merged 2 commits into from
Jun 21, 2022

Conversation

dylant-da
Copy link
Contributor

This is useful for development, when testing the daml-sdk with edits that require changes to our fork of ghc.

CHANGELOG_BEGIN
CHANGELOG_END

@dylant-da dylant-da requested a review from akrmn June 21, 2022 10:55
@akrmn
Copy link
Contributor

akrmn commented Jun 21, 2022 •
edited
Loading

I think this PR should also add ${BAZEL_MODE_FLAGS[@]:-} to the bazel build call on line 213.

EDIT: Actually, I think that should have been the case all along, otherwise I think daml-sdk-head --profiling would have to rebuild everything once it got to bazel build //release:release

akrmn
akrmn approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@akrmn akrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dylant-da dylant-da merged commit 2edd4c0 into main Jun 21, 2022
@dylant-da dylant-da deleted the set-ghc-in-daml-sdk-head branch June 21, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrmn akrmn akrmn approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylant-da @akrmn