Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of sandbox-classic module and binary #14201

Merged
merged 11 commits into from
Jun 21, 2022

Conversation

skisel-da
Copy link
Contributor

CHANGELOG_BEGIN
CHANGELOG_END

@skisel-da skisel-da marked this pull request as ready for review June 16, 2022 13:05
@skisel-da skisel-da requested review from a team and garyverhaegen-da as code owners June 16, 2022 13:05
@skisel-da skisel-da marked this pull request as draft June 16, 2022 13:15
release/util.bzl Outdated Show resolved Hide resolved
@skisel-da skisel-da marked this pull request as ready for review June 17, 2022 08:09
Copy link
Contributor

@simonmaxen-da simonmaxen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tudor-da
Copy link
Contributor

Nice job! Can you run full compat CI job as well before merging? (e.g. add run-full-compat: true after changelog_end in the git commit message)

@skisel-da skisel-da force-pushed the skisel-da/sandbox-classic-full-removal branch from 9b7f321 to 1b4f804 Compare June 20, 2022 07:28
run-full-compat: true
@skisel-da skisel-da force-pushed the skisel-da/sandbox-classic-full-removal branch from 1b4f804 to 50b5f91 Compare June 20, 2022 07:29
@skisel-da skisel-da merged commit 6a80a1a into main Jun 21, 2022
@skisel-da skisel-da deleted the skisel-da/sandbox-classic-full-removal branch June 21, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants