Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in daml-lf/interface, resolve choices directly from DefInterface #14057

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

S11001001
Copy link
Contributor

Fixes #14038.

@S11001001 S11001001 added component/daml-lf DAML-LF team/ledger-clients Related to the Ledger Clients team's components. labels Jun 1, 2022
@S11001001 S11001001 self-assigned this Jun 1, 2022
@S11001001 S11001001 requested a review from a team June 1, 2022 19:51
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of that so quickly.

@S11001001
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@S11001001 S11001001 enabled auto-merge (squash) June 2, 2022 10:30
@S11001001 S11001001 merged commit 4caba37 into main Jun 2, 2022
@S11001001 S11001001 deleted the 14038-no-inherited-choices-knowledge branch June 2, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/daml-lf DAML-LF team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use anymore inheritedChoice from GenTemplateImplements in interface reader
3 participants