fix daml-sdk Docker image #14055
Merged
fix daml-sdk Docker image #14055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the default image changed from Focal to Jammy, and for whatever reason that completely breaks `curl`. This pins us to Focal (for better or worse), as well as switching to the new JRE-only images (much smaller size & attack surface than the full JDK images). CHANGELOG_BEGIN CHANGELOG_END
cocreature
reviewed
Jun 1, 2022
ci/docker/daml-sdk/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM eclipse-temurin:11 | |||
| FROM eclipse-temurin:11-jre-focal | |||
There was a problem hiding this comment.
I’m not quite sure the move to JRE only makes sense. You shouldn’t use those images in production anyway. I think the usecases that I personally find somewhat sensible is development & CI. And for those a JDK actually seems more useful.
That said, I’m happy to leave the decision here to others.
There was a problem hiding this comment.
Makes sense. Thanks!
cocreature
approved these changes
Jun 1, 2022
Merged
garyverhaegen-da
added a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the default image changed from Focal to Jammy, and for whatever reason that completely breaks
curl.This pins us to Focal (for better or worse), as well as switching to the new JRE-only images (much smaller size & attack surface than the full JDK images).
CHANGELOG_BEGIN
CHANGELOG_END