Ledger API Tests: use real ledger ID everywhere. #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
461c398 to
ce5cc79
Compare
gabor-aranyossy
suggested changes
May 27, 2019
...g-utils/src/main/scala/com/digitalasset/ledger/api/testing/utils/AkkaBeforeAndAfterAll.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
.../lib/scala/com/digitalasset/platform/tests/integration/ledger/api/LedgerTestingHelpers.scala
Show resolved
Hide resolved
ledger/ledger-api-test-tool/src/main/scala/com/daml/ledger/api/testtool/ToolReporter.scala
Outdated
Show resolved
Hide resolved
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
2 times, most recently
from
ae4f53e to
a2e30bb
Compare
5 tasks
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
2 times, most recently
from
21608ab to
6492dd8
Compare
gleber-da
commented
May 31, 2019
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
gleber-da
changed the title
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
2 times, most recently
from
acd74cb to
7a29719
Compare
.../scala/com/digitalasset/platform/tests/integration/ledger/api/ActiveContractsServiceIT.scala
Outdated
Show resolved
Hide resolved
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
cdd158e to
7f988dd
Compare
gabor-aranyossy
suggested changes
May 31, 2019
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Outdated
Show resolved
Hide resolved
...ntegration-tests/src/test/lib/scala/com/digitalasset/platform/apitesting/LedgerContext.scala
Show resolved
Hide resolved
...st/itsuite/scala/com/digitalasset/platform/tests/integration/ledger/api/ResetServiceIT.scala
Outdated
Show resolved
Hide resolved
...st/itsuite/scala/com/digitalasset/platform/tests/integration/ledger/api/ResetServiceIT.scala
Show resolved
Hide resolved
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
5f0256b to
9c4744e
Compare
gabor-aranyossy
approved these changes
May 31, 2019
gleber-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
9c4744e to
be6a2b1
Compare
This fetches and caches ledger ID inside LedgerContext.SingleChannelContext to reduce number of calls into the Ledger API under test.
gerolf-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
be6a2b1 to
e38a718
Compare
gerolf-da
force-pushed
the
ledger-api-tests-use-real-ledger-id
branch
from
e38a718 to
455e80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.
Prerequisite for #1372
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.