Publish daml-lf encoder, parser and error-test-lib [KVL-1424] #13730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG_BEGIN CHANGELOG_END
hubert-da
requested review from
a team,
remyhaemmerle-da and
garyverhaegen-da
as code owners
hubert-da
commented
Apr 28, 2022
hubert-da
commented
Apr 28, 2022
| @@ -41,7 +41,6 @@ da_scala_library( | |||
| name = "error-test-utils", | |||
| srcs = glob(["src/test/utils/**/*.scala"]), | |||
| scala_deps = [], | |||
| tags = ["maven_coordinates=com.daml:error-test-package:__VERSION__"], | |||
There was a problem hiding this comment.
I don't think we used it.
remyhaemmerle-da
requested changes
Apr 28, 2022
There was a problem hiding this comment.
We do not want the encoder to be publicly available. The main reasons are :
- We want to discourage as much as possible people to create production dars without passing through
damlc. - We do not want to offer any grantee about the encoder, to anybody outside DA.
remyhaemmerle-da
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double-checked and we need all these 3 libraries to re-enable tests in kvutils.