Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependencies for create-daml-app #13089

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix dependencies for create-daml-app #13089

merged 1 commit into from
Feb 25, 2022

Conversation

cocreature
Copy link
Contributor

No reason to incldue daml-trigger by default.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Fix dependencies for create-daml-app
c80d6da 
No reason to incldue daml-trigger by default.

changelog_begin
changelog_end
@cocreature cocreature added the needs-backport Candidate fix for backporting to the latest release branch label Feb 25, 2022
@cocreature cocreature requested review from akrmn, a user and garyverhaegen-da February 25, 2022 14:54
cocreature added a commit that referenced this pull request Feb 25, 2022
@cocreature
Backport: Fix dependencies for create-daml-app
a59e865 
Backport from #13089

changelog_begin
changelog_end
@cocreature cocreature mentioned this pull request Feb 25, 2022
Merged
7 tasks
garyverhaegen-da
garyverhaegen-da approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cocreature cocreature enabled auto-merge (squash) February 25, 2022 15:01
cocreature added a commit that referenced this pull request Feb 25, 2022
@cocreature
Backport: Fix dependencies for create-daml-app (#13090)
d54b9fa 
Backport from #13089

changelog_begin
changelog_end
ghost
ghost approved these changes Feb 25, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cocreature cocreature merged commit 49e04c1 into main Feb 25, 2022
@cocreature cocreature deleted the fix-gsg-deps branch February 25, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@akrmn akrmn akrmn approved these changes

Assignees
No one assigned
Labels
needs-backport Candidate fix for backporting to the latest release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocreature @akrmn @garyverhaegen-da