ledger-api-bench-tool - do not require using ledgers with UserManagementService implemented [DPP-846] #12957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with ledger-api-bench-tool. CHANGELOG_BEGIN CHANGELOG_END
pbatko-da
approved these changes
Feb 16, 2022
| case None => Future.successful(()) | ||
| case Some(_) => | ||
| // Only if the submission config is provided we can compute what parties the user can observe. | ||
| // Otherwise we set an empty list as a default not to prematurely block the stream reading phase. |
There was a problem hiding this comment.
How the stream reading phase could be blocked?
There was a problem hiding this comment.
Discussed offline that the comment is not precise. Fixed in 60fc2a0
kamil-da
deleted the
kamil-da/benchtooldont-use-user-mgmt-service-when-not-needed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up PR to #12871 .
This change restores the possibility to connect to ledgers that don't implement the
UserManagementServicewith theledger-api-bench-tool.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.