No parties in create-daml-app's daml.yaml template, #12952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
reviewed
Feb 15, 2022
adriaanm-da
force-pushed
the
navigator-users-create-daml-app
branch
from
b03b272 to
551c4e1
Compare
cocreature
approved these changes
Feb 15, 2022
cocreature
added a commit
that referenced
this pull request
Feb 15, 2022
Complements #12952 which drops it from create-daml-app by also dropping it from the rest. Couldn’t find any docs or other stuff that is broken by this. changelog_begin changelog_end
7 tasks
... so that Navigator shows users for login by default. When parties are specified explicitly in daml.yaml, navigator uses those instead of querying user management for the list of users a user can log in as. These days, it actually doesn't make sense to list the parties in the daml.yaml. Navigator will query party mgmt for a list of known parties. We don't implicitly allocate parties (anymore), so unclear why this section is still here. The users for the template are created by the init script (see Setup.daml). See #12945 CHANGELOG_BEGIN CHANGELOG_END
adriaanm-da
force-pushed
the
navigator-users-create-daml-app
branch
from
551c4e1 to
e281b37
Compare
cocreature
added a commit
that referenced
this pull request
Feb 15, 2022
Complements #12952 which drops it from create-daml-app by also dropping it from the rest. Couldn’t find any docs or other stuff that is broken by this. changelog_begin changelog_end
|
@rgugliel-da Ian Woodgate reported today that the Canton examples are likely running into this problem as well. The login screen for navigator does not show any users for him. |
Done (https://github.com/DACH-NY/canton/pull/9197), thanks for the ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that Navigator shows users for login by default.
When parties are specified explicitly in daml.yaml,
navigator uses those instead of querying user management
for the list of users a user can log in as.
These days, it actually doesn't make sense to list the
parties in the daml.yaml. Navigator will query party
mgmt for a list of known parties. We don't implicitly
allocate parties (anymore), so unclear why this section
is still here.
The users for the template are created by the init script
(see Setup.daml).
See #12945
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.