Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on hosted nodes #12901

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Drop dependency on hosted nodes #12901

merged 1 commit into from
Feb 14, 2022

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented Feb 13, 2022

This should hopefully get CI working again.

There are two changes in here:

  1. We can no longer change our patched Bazel. I didn’t switch away
    from the current patched version for now (we upload it to gcp bucket
    so it still works fine even if we cannot build it) but if we upgrade,
    we need to go to an unpatched version for now.
  2. We need to get az from dev-env. I tested the self service compat
    job stuff and it works fine with this but there is a chance other
    parts don’t.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature force-pushed the no-hosted-nodes branch 4 times, most recently from 8830e6c to e13450b Compare February 13, 2022 08:28
@cocreature cocreature marked this pull request as ready for review February 13, 2022 08:29
This should hopefully get CI working again.

There are two changes in here:

1. We can no longer change our patched Bazel. I didn’t switch away
   from the current patched version for now (we upload it to gcp bucket
   so it still works fine even if we cannot build it) but if we upgrade,
   we need to go to an unpatched version for now.
2. We need to get `az` from dev-env. I tested the self service compat
   job stuff and it works fine with this but there is a chance other
   parts don’t.

changelog_begin
changelog_end
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garyverhaegen-da garyverhaegen-da merged commit 9e1e42d into main Feb 14, 2022
@garyverhaegen-da garyverhaegen-da deleted the no-hosted-nodes branch February 14, 2022 01:49
garyverhaegen-da added a commit that referenced this pull request Feb 14, 2022
This reverts commit 9e1e42d.

Microsoft seems to have given us our free parallel jobs again.

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da added a commit that referenced this pull request Feb 14, 2022
This reverts a small part of 9e1e42d
(#12901).

Microsoft seems to have given us our free parallel jobs back, so we can
run the patch_bazel job again.

Fixes #12900.

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da added a commit that referenced this pull request Feb 14, 2022
This reverts a small part of 9e1e42d
(#12901).

Microsoft seems to have given us our free parallel jobs back, so we can
run the patch_bazel job again.

Fixes #12900.

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da added a commit that referenced this pull request Feb 14, 2022
This reverts a small part of 9e1e42d
(#12901).

Microsoft seems to have given us our free parallel jobs back, so we can
run the patch_bazel job again.

Fixes #12900.

CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da garyverhaegen-da mentioned this pull request Feb 16, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants