Create alias contracts in frontend in create-daml-app #12848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
force-pushed
the
public-party-refactor
branch
2 times, most recently
from
4768a0d to
e33612e
Compare
Creating them in the setup script is nice but it makes it much harder to port this to Daml hub where we cannot rely on this. This also requires figuring out the public party in the frontend. I’ve chosen to infer it from the user rights which seems broadly sensible. For the backwards compat mode, I just hardcoded it because there isn’t a great way to figure it out. changelog_begin changelog_end
cocreature
force-pushed
the
public-party-refactor
branch
from
e33612e to
fe5b8d4
Compare
7 tasks
cocreature
commented
Feb 10, 2022
| @@ -100,7 +113,8 @@ const LoginScreen: React.FC<Props> = ({onLogin}) => { | |||
| <DamlHubLoginBtn | |||
| onLogin={creds => { | |||
| if (creds) { | |||
| login({party:creds.party, user: {userId: creds.partyName, primaryParty: creds.party}, token:creds.token}); | |||
| // TODO (MK) Fix public party in Daml hub | |||
There was a problem hiding this comment.
both of these todos were already broken before, just breaking them slightly more. working on the daml hub one, #12849 tracks the auth0 part which the runtime team will work on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating them in the setup script is nice but it makes it much harder
to port this to Daml hub where we cannot rely on this.
This also requires figuring out the public party in the frontend.
I’ve chosen to infer it from the user rights which seems broadly
sensible.
For the backwards compat mode, I just hardcoded it because there isn’t
a great way to figure it out.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.