Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for canton-repl #12772

Merged
merged 14 commits into from
Feb 8, 2022
Merged

Add an integration test for canton-repl #12772

merged 14 commits into from
Feb 8, 2022

Conversation

sofiafaro-da
Copy link
Contributor

@sofiafaro-da sofiafaro-da commented Feb 4, 2022

Adds an integration test for daml canton-repl. The test boots up the repl and sees if it's actually connected to a running local participant and domain.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@sofiafaro-da sofiafaro-da marked this pull request as ready for review February 7, 2022 12:38
@sofiafaro-da sofiafaro-da requested a review from a user February 7, 2022 12:39
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

WORKSPACE Outdated Show resolved Hide resolved
@sofiafaro-da sofiafaro-da enabled auto-merge (squash) February 7, 2022 14:14
@sofiafaro-da sofiafaro-da disabled auto-merge February 8, 2022 12:15
@sofiafaro-da sofiafaro-da enabled auto-merge (squash) February 8, 2022 13:22
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of fun ...

@sofiafaro-da sofiafaro-da merged commit e12faa3 into main Feb 8, 2022
@sofiafaro-da sofiafaro-da deleted the canton-repl-test branch February 8, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants