Migrate Haskell tests to Sandbox on X #12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
The diff here looks extremely confusing. sandbox-classic is now sandbox on x not sandbox classic so this isn’t a typo. It is really moving to sandbox on x. changelog_begin changelog_end
cocreature
force-pushed
the
hs-sandbox-test
branch
from
eb08889 to
ed63075
Compare
cocreature
commented
Feb 7, 2022
| @@ -327,7 +327,7 @@ tGetLedgerConfiguration withSandbox = testCase "tGetLedgerConfiguration" $ run w | |||
| xs <- getLedgerConfiguration lid | |||
| Just (Right config) <- liftIO $ timeout 1 (takeStream xs) | |||
| let expected = LedgerConfiguration { | |||
| maxDeduplicationTime = Duration {durationSeconds = 86400, durationNanos = 0}} | |||
| maxDeduplicationTime = Duration {durationSeconds = 1800, durationNanos = 0}} | |||
There was a problem hiding this comment.
@tudor-da I assume this is expected?
There was a problem hiding this comment.
Yes. This is due to an optimization for Sandbox-on-X. For simplicity, deduplication is done in-memory for Sandbox-on-X. For that reason (i.e to avoid OOMs), the default maxDeduplicationTime is 30 minutes with the maximum configurable to one hour.
cocreature
requested review from
nickchapman-da and
sofiafaro-da
as code owners
cocreature
requested review from
a user and
tudor-da
and removed request for
sofiafaro-da
Sorry for the confusion. Indeed, Sandbox-on-X is exposed underneath the sandbox-classic CLI. We'll rename it one go soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff here looks extremely confusing. sandbox-classic is now
sandbox on x not sandbox classic so this isn’t a typo. It is really
moving to sandbox on x.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.