Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a --wall-clock-time option for the Canton sandbox #12733

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

cocreature
Copy link
Contributor

We have this in so many of our examples that I expect a lot of users
have it as well and we can trivially support it so it seems nice to
not break things more for our users than necessary.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

We have this in so many of our examples that I expect a lot of users
have it as well and we can trivially support it so it seems nice to
not break things more for our users than necessary.

changelog_begin
changelog_end
@cocreature cocreature requested review from a user and sofiafaro-da February 3, 2022 09:44
Copy link
Contributor

@sofiafaro-da sofiafaro-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

@cocreature cocreature merged commit f6344a2 into main Feb 3, 2022
@cocreature cocreature deleted the sandbox-wallclock branch February 3, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants