Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky part of config management test #12726

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

mziolekda
Copy link
Contributor

The flaky part of the test relies on a certain outcome of a race condition between the participant and committer execution paths. It should always be won by the participant, but as recent CI error testifies, it is not always guaranteed. Removing it altogether.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

CHANGELOG_BEGIN
CHANGELOG_END
@mziolekda mziolekda requested review from a team as code owners February 2, 2022 21:01
@@ -90,14 +80,6 @@ final class ConfigManagementServiceIT extends LedgerTestSuite {
response3.timeModel.equals(response1.timeModel),
"Restoring the original time model failed",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this message as well? The intention probably changed but the explanation is wrong

@mziolekda mziolekda enabled auto-merge (squash) February 2, 2022 21:22
@mziolekda mziolekda merged commit 0f0183a into main Feb 2, 2022
@mziolekda mziolekda deleted the mziolek/simplify-flaky-config-test-dpp-885 branch February 2, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants