Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Seq instead of Vector in user mgmt apis #12725

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Use Seq instead of Vector in user mgmt apis #12725

merged 1 commit into from
Feb 3, 2022

Conversation

adriaanm-da
Copy link
Contributor

For consistency with other APIs in this area.
Note that some pre-existing APIs use List instead of Seq,
but at least those use the same underlying implementation.

This was originally developed (and reviewed) as part of #12187

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@adriaanm-da adriaanm-da mentioned this pull request Feb 2, 2022
Merged
7 tasks
@adriaanm-da
Copy link
Contributor Author

Test failure is spurious?

//language-support/scala/codegen-sample-app:ScalaCodeGenIT              TIMEOUT in 300.6s

@adriaanm-da
Use Seq instead of Vector in user mgmt apis
6829f0d 
For consistency with other APIs in this area.
Note that some pre-existing APIs use `List` instead of `Seq`,
but at least those use the same underlying implementation.

CHANGELOG_BEGIN
CHANGELOG_END
@adriaanm-da adriaanm-da force-pushed the adriaanm-usermgmt-seq branch from a644fe4 to 6829f0d Compare February 3, 2022 08:53
meiersi-da
meiersi-da approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @adriaanm-da 👍

@adriaanm-da adriaanm-da merged commit 810554b into main Feb 3, 2022
@adriaanm-da adriaanm-da deleted the adriaanm-usermgmt-seq branch February 3, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanobaghino-da stefanobaghino-da stefanobaghino-da approved these changes

@meiersi-da meiersi-da meiersi-da approved these changes

@S11001001 S11001001 Awaiting requested review from S11001001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriaanm-da @meiersi-da @stefanobaghino-da