Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sandbox-on-X] Source record time once and pass downstream #12722

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

tudor-da
Copy link
Contributor

@tudor-da tudor-da commented Feb 2, 2022

This PR reduces chances of further timing inconsistency bugs in the future: Source the recordTime uniquely for all validations.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@tudor-da tudor-da requested a review from a team as a code owner February 2, 2022 19:21
@tudor-da tudor-da merged commit c11d4a7 into main Feb 3, 2022
@tudor-da tudor-da deleted the tudor/record-time-cleanup branch February 3, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants