Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cda: use aliases in the first feature section of docs #12720

Merged
1 commit merged into from
Feb 3, 2022
Merged

cda: use aliases in the first feature section of docs #12720

1 commit merged into from
Feb 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2022

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@ghost ghost force-pushed the alias_first_feature branch 2 times, most recently from 85dcf0c to 7eddb9f Compare February 3, 2022 11:23
@ghost ghost force-pushed the alias_first_feature branch from 7eddb9f to 6ccb971 Compare February 3, 2022 11:51
@ghost ghost marked this pull request as ready for review February 3, 2022 11:52
@ghost ghost requested a review from cocreature February 3, 2022 11:52
cocreature
cocreature approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible thanks! Can we change the create-daml-app tests to use the aliases?

@ghost
Copy link
Author

ghost commented Feb 3, 2022

Yes, I think it would be good to add a test for the aliases. Let's do that in the following PR.

@ghost ghost merged commit 9e1fe24 into main Feb 3, 2022
@ghost ghost deleted the alias_first_feature branch February 3, 2022 17:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature