Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch compat tests over to sandbox on x #12716

Merged
merged 13 commits into from
Feb 3, 2022
Merged

Switch compat tests over to sandbox on x #12716

merged 13 commits into from
Feb 3, 2022

Conversation

cocreature
Copy link
Contributor

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature force-pushed the compat-no-kv branch 4 times, most recently from 48f7dd5 to 26ffb43 Compare February 2, 2022 15:39
@cocreature cocreature marked this pull request as ready for review February 2, 2022 15:40
@cocreature cocreature requested review from sofiafaro-da and a user February 2, 2022 15:40
cocreature added a commit that referenced this pull request Feb 2, 2022
@cocreature
Drop sandbox-kv from the SDK
2eba738 
Depends on #12716 and #12625 (CI fails until they are merged & this
is rebased so no chance of merging this accidentally).

changelog_begin
changelog_end
@cocreature cocreature mentioned this pull request Feb 2, 2022
Merged
7 tasks
cocreature added a commit that referenced this pull request Feb 2, 2022
@cocreature
Drop sandbox-kv from the SDK
92a003d 
Depends on #12716 and #12625 (CI fails until they are merged & this
is rebased so no chance of merging this accidentally).

changelog_begin
changelog_end
cocreature added a commit that referenced this pull request Feb 2, 2022
@cocreature
Drop sandbox-kv from the SDK
c8e206b 
Depends on #12716 and #12625 (CI fails until they are merged & this
is rebased so no chance of merging this accidentally).

changelog_begin
changelog_end
@cocreature
Switch compat tests over to sandbox on x
348016f 
changelog_begin
changelog_end
@cocreature
.
f023dad 
changelog_begin
changelog_end
@cocreature
.
7dcf716 
changelog_begin
changelog_end
@cocreature
.
156d6a1 
changelog_begin
changelog_end
@cocreature
.
4d68f8e 
changelog_begin
changelog_end
@cocreature
.
13bf090 
changelog_begin
changelog_end
@cocreature
.
53be9d7 
changelog_begin
changelog_end
@cocreature
.
8a55b47 
changelog_begin
changelog_end
@cocreature
.
6786222 
changelog_begin
changelog_end
@cocreature
.
145512f 
changelog_begin
changelog_end
@cocreature
.
1c8c719 
changelog_begin
changelog_end
@cocreature
.
cac2970 
changelog_begin
changelog_end
@cocreature
.
17702e4 
changelog_begin
changelog_end
sofiafaro-da
sofiafaro-da approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@sofiafaro-da sofiafaro-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

compatibility/bazel_tools/run_jar.cc.tpl
using bazel::tools::cpp::runfiles::Runfiles;

/*
NOTE (MK): Why is this not just an sh_binary?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no

@cocreature cocreature merged commit 97db5ac into main Feb 3, 2022
@cocreature cocreature deleted the compat-no-kv branch February 3, 2022 10:32
cocreature added a commit that referenced this pull request Feb 3, 2022
@cocreature
Drop sandbox-kv from the SDK
f6ac5b4 
Depends on #12716 and #12625 (CI fails until they are merged & this
is rebased so no chance of merging this accidentally).

changelog_begin
changelog_end
cocreature added a commit that referenced this pull request Feb 3, 2022
@cocreature
Drop sandbox-kv from the SDK (#12717)
6ff7dc2 
Depends on #12716 and #12625 (CI fails until they are merged & this
is rebased so no chance of merging this accidentally).

changelog_begin
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofiafaro-da sofiafaro-da sofiafaro-da approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @sofiafaro-da