[ledger-api-test-tool] - Remove static time flag which was replaced by a feature descriptor #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y a feature descriptor changelog_begin changelog_end
ghost
approved these changes
Feb 2, 2022
Comment on lines
-232
to
-235
| opt[Unit]("static-time") | ||
| .optional() | ||
| .action((_, c) => c.copy(staticTime = true)) | ||
| .text("Must be enabled if the ledger is using static time") |
There was a problem hiding this comment.
Are we sure it's not relied upon in integrations? If it is, we should rather deprecate it.
There was a problem hiding this comment.
I would prefer we break and have to fix those integrations. The flag already does nothing.
There was a problem hiding this comment.
Afaik we have no static tests in vmbc, nor in pkv. This was recently introduced so I would not expect it to be used anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.