[Sandbox-on-X] Fix record time assignment #12706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tudor-da
force-pushed
the
tudor/sox/fix-record-time-assignment
branch
3 times, most recently
from
469c502 to
cdb9319
Compare
changelog_begin changelog_end
tudor-da
force-pushed
the
tudor/sox/fix-record-time-assignment
branch
from
cdb9319 to
8c75979
Compare
tudor-da
commented
Feb 2, 2022
ledger/sandbox-on-x/src/main/scala/com/daml/ledger/sandbox/bridge/validate/SequenceImpl.scala
Show resolved
Hide resolved
mziolekda
reviewed
Feb 2, 2022
| @@ -19,33 +19,48 @@ import scala.util.chaining._ | |||
| class DeduplicateStateSpec extends AnyFlatSpec with Matchers { | |||
| behavior of classOf[DeduplicationState].getSimpleName | |||
|
|
|||
| private val initialTime = Time.Timestamp.now() | |||
| private val t0 = Time.Timestamp.now() | |||
There was a problem hiding this comment.
Those tests have become more transparent now
mziolekda
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential inconsistency wrt to deduplication behavior and accepted transactions' record time. More specifically, the inconsistency was stemming from the fact that deduplication relied on its own record time which was different from the actual assigned record time.
Additionally to the fix, a small refactoring was applied to
SequenceImpl.changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.