Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document to test releases with the Canton-based sandbox #12702

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Document to test releases with the Canton-based sandbox #12702

merged 1 commit into from
Feb 2, 2022

Conversation

stefanobaghino-da
Copy link
Contributor

This could not be achieved previously due to an issue that has
been fixed by https://github.com/DACH-NY/canton/pull/8475.

The next release should be tested again with the Canton-based
sandbox to ensure it works on both Windows and MacOS/Linux.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da
Document to test releases with the Canton-based sandbox
a8495a5 
This could not be achieved previously due to an issue that has
been fixed by https://github.com/DACH-NY/canton/pull/8475.

The next release should be tested again with the Canton-based
sandbox to ensure it works on both Windows and MacOS/Linux.

changelog_begin
changelog_end
@stefanobaghino-da stefanobaghino-da force-pushed the ste/test-release-with-cantbox branch from b63b13e to a8495a5 Compare February 2, 2022 09:16
cocreature
cocreature approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we need a few more changes for things to work with the new gsg but I’ll take care of those in a separate PR.

@stefanobaghino-da
Copy link
Contributor Author

Thanks, we need a few more changes for things to work with the new gsg but I’ll take care of those in a separate PR.

I'll wait for this week's snapshot release to be tested (should be done today) before merging this PR, this would leave you one full week to add those changes without any likely misunderstanding on what to test. Thanks!

@cocreature
Copy link
Contributor

I'll wait for this week's snapshot release to be tested (should be done today) before merging this PR, this would leave you one full week to add those changes without any likely misunderstanding on what to test. Thanks!

no need to wait, we need those changes either way. The current instructions are just broken.

@stefanobaghino-da stefanobaghino-da enabled auto-merge (squash) February 2, 2022 09:24
@stefanobaghino-da stefanobaghino-da merged commit 8bd908e into main Feb 2, 2022
@stefanobaghino-da stefanobaghino-da deleted the ste/test-release-with-cantbox branch February 2, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanobaghino-da @cocreature