Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make daml-script docs work with a Canton sandbox #12695

Merged
merged 14 commits into from
Feb 2, 2022
Merged

Conversation

cocreature
Copy link
Contributor

This addresses a few issues:

  1. The --wallclock-time option does not work.
  2. Display names are garbage so dropped the "solution" for
    listKnownParties.
  3. We cannot allocate fixed parties even with
    allocatePartyWithHint. Switched to --output-file and user mgmt.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This addresses a few issues:

1. The `--wallclock-time` option does not work.
2. Display names are garbage so dropped the "solution" for
`listKnownParties`.
3. We cannot allocate fixed parties even with
`allocatePartyWithHint`. Switched to `--output-file` and user mgmt.

changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
.
changelog_begin
changelog_end
Copy link
Contributor

@nickchapman-da nickchapman-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
one (pre existing) typo

The ``--output-file`` option instructs ``daml script`` to write the
result of the given ``--script-name`` to the given filename (creating
the file if it does not exist; overwriting it otherwise). This is most
usfeful if the given program has a type ``Script b``, where ``b`` is a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo on "useful"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch fixed

@cocreature cocreature enabled auto-merge (squash) February 2, 2022 16:55
@cocreature
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature cocreature merged commit 7a5172c into main Feb 2, 2022
@cocreature cocreature deleted the script-docs-canton branch February 2, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants