-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make daml-script docs work with a Canton sandbox #12695
Conversation
This addresses a few issues: 1. The `--wallclock-time` option does not work. 2. Display names are garbage so dropped the "solution" for `listKnownParties`. 3. We cannot allocate fixed parties even with `allocatePartyWithHint`. Switched to `--output-file` and user mgmt. changelog_begin changelog_end
e118e7a
to
51a69d5
Compare
changelog_begin changelog_end
changelog_begin changelog_end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
one (pre existing) typo
docs/source/daml-script/index.rst
Outdated
The ``--output-file`` option instructs ``daml script`` to write the | ||
result of the given ``--script-name`` to the given filename (creating | ||
the file if it does not exist; overwriting it otherwise). This is most | ||
usfeful if the given program has a type ``Script b``, where ``b`` is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo on "useful"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch fixed
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This addresses a few issues:
--wallclock-time
option does not work.listKnownParties
.allocatePartyWithHint
. Switched to--output-file
and user mgmt.changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.