Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to grpc 1.44.0 with scalapb/netty/grpc/protobuf/guava in proven combination #12628

Merged
merged 8 commits into from
Feb 3, 2022
Merged

upgrade to grpc 1.44.0 with scalapb/netty/grpc/protobuf/guava in proven combination #12628

merged 8 commits into from
Feb 3, 2022

Conversation

dasormeter
Copy link
Collaborator

@dasormeter dasormeter commented Jan 27, 2022 •
edited
Loading

We are currently running in a slightly oddball combo of netty and grpc (at least not a vetted combo as per netty documentation) - this pr upticks to the most up to data blessed netty/grpc/scalapb and friends combination

  • Update scalapb version and associated SHA
  • Match up netty/grpc/guava/protobuf with known to work blessed triad based on https://github.com/grpc/grpc-java/blob/master/SECURITY.md#netty
  • Uptick akka version and make necessary changes to deal with deprecated interface (createGraph instead of create and the need to implement size method
grpc-netty version netty-handler version netty-tcnative-boringssl-static version
1.35.x-1.41.x 4.1.52.Final 2.0.34.Final
1.42.x-1.43.x 4.1.63.Final 2.0.38.Final
1.44.x 4.1.72.Final 2.0.46.Final
  • Move versions of guava and protobuf to top level definitions next to grpc to remind that they should be updated in concert with changes to grpc and Netty

@dasormeter dasormeter force-pushed the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch from d7ee465 to 4a53b0c Compare January 27, 2022 14:52
dasormeter
dasormeter commented Jan 27, 2022
View reviewed changes
WORKSPACE Outdated
@@ -685,7 +685,7 @@ proto_library(
visibility = ["//visibility:public"],
)
""",
sha256 = "e2dc7ad98f2bc1a78442a3e20eeef0381be008c18bf22f0dcb56283981977e01",
sha256 = "9cfede22ded095d600d9cc68a4aa83fe210e2628b2a81bf91f4de2d576a50984",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aherrmann-da @cocreature can we move this SHA to bazel_tools/scalapb.bzl so it is closer to where you are upticking the scalapb version and it is clearer it needs to move in tandem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure move it around as you see fit

cocreature
cocreature approved these changes Jan 27, 2022
View reviewed changes
bazel-java-deps.bzl Show resolved Hide resolved
@dasormeter
Copy link
Collaborator Author

dasormeter commented Jan 27, 2022 •
edited
Loading

These tests look to be failing with the straight uptick

  • //ledger/sandbox-classic:sandbox-classic-tests_test_suite_src_test_suite_scala_platform_sandbox_auth_CheckHealthAuthIT.scala TIMEOUT in 300.6s
  • /home/vsts/.cache/bazel/_bazel_vsts/9b01b58e95c1fb4c476c067a6a807d1d/execroot/com_github_digital_asset_daml/bazel-out/k8-opt/testlogs/ledger/sandbox-classic/sandbox-classic-tests_test_suite_src_test_suite_scala_platform_sandbox_auth_CheckHealthAuthIT.scala/test.log
  • //ledger/sandbox-classic:sandbox-classic-tests_test_suite_src_test_suite_scala_platform_sandbox_services_reflection_ReflectionIT.scala TIMEOUT in 300.6s
  • /home/vsts/.cache/bazel/_bazel_vsts/9b01b58e95c1fb4c476c067a6a807d1d/execroot/com_github_digital_asset_daml/bazel-out/k8-opt/testlogs/ledger/sandbox-classic/sandbox-classic-tests_test_suite_src_test_suite_scala_platform_sandbox_services_reflection_ReflectionIT.scala/test.log
  • //daml-assistant/integration-tests:create-daml-app-tests-proj-name FAILED in 127.4s
  • /home/vsts/.cache/bazel/_bazel_vsts/9b01b58e95c1fb4c476c067a6a807d1d/execroot/com_github_digital_asset_daml/bazel-out/k8-opt/testlogs/daml-assistant/integration-tests/create-daml-app-tests-proj-name/test.log

@dasormeter dasormeter requested review from S11001001 and a team as code owners January 27, 2022 20:19
@dasormeter dasormeter force-pushed the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch from 8072861 to fbd16c1 Compare January 27, 2022 20:20
ghost
ghost reviewed Jan 28, 2022
View reviewed changes
bazel_tools/scalapb.bzl Show resolved Hide resolved
deps.bzl Outdated Show resolved Hide resolved
@dasormeter dasormeter force-pushed the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch 3 times, most recently from 6377883 to 479a389 Compare January 31, 2022 18:03
@ghost
Copy link

ghost commented Feb 1, 2022

com.daml.lf.engine.script.ScriptF$FailedCmd: Command createUser failed: Request to /v1/user/create with Some({"isAdmin":false,"primaryParty":"Alice","rights":[],"userId":"u1"}) failed with status 200 OK: List({"result":{},"status":200})

Ah, that classic failure code, "200 OK".

@cocreature
Copy link
Contributor

Ah, that classic failure code, "200 OK".

rebase, we fixed that yesterday

@dasormeter dasormeter force-pushed the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch from 479a389 to bd6667c Compare February 1, 2022 15:01
@dasormeter dasormeter force-pushed the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch from bd6667c to 5afa1f2 Compare February 2, 2022 17:54
@dasormeter dasormeter merged commit e70237a into main Feb 3, 2022
@dasormeter dasormeter deleted the move-to-blessed-tetrad-grpc-netty-protobuf-scalapb branch February 3, 2022 13:38
@dasormeter dasormeter changed the title upgrade scalapb/netty/grpc/protobuf in proven combination upgrade to grpc 1.44.0 with scalapb/netty/grpc/protobuf in proven combination Feb 3, 2022
@dasormeter dasormeter changed the title upgrade to grpc 1.44.0 with scalapb/netty/grpc/protobuf in proven combination upgrade to grpc 1.44.0 with scalapb/netty/grpc/protobuf/guava in proven combination Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@S11001001 S11001001 S11001001 approved these changes

@gerolf-da gerolf-da Awaiting requested review from gerolf-da

@mziolekda mziolekda Awaiting requested review from mziolekda

@stefanobaghino-da stefanobaghino-da Awaiting requested review from stefanobaghino-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dasormeter @cocreature @S11001001 @SamirTalwar