-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User management] Enforce 1k user rights limit [DPP-833] #12558
Merged
pbatko-da
merged 8 commits into
main
from
pbatko/persistent-user-management-rights-limits
Jan 27, 2022
Merged
[User management] Enforce 1k user rights limit [DPP-833] #12558
pbatko-da
merged 8 commits into
main
from
pbatko/persistent-user-management-rights-limits
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbatko-da
changed the title
[User management] Enforce 1k rights limit [DPP-833]
[User management] Enforce 1k user rights limit [DPP-833]
Jan 24, 2022
CHANGELOG_BEGIN Ledger API Specification: Maximum number of user rights per single user is now added to UserManagementFeature in VersionService endpoint. CHANGELOG_END
CHANGELOG_BEGIN Ledger API Specification: Maximum number of user rights per single user is now added to UserManagementFeature in VersionService endpoint. CHANGELOG_END
pbatko-da
force-pushed
the
pbatko/persistent-user-management-rights-limits
branch
from
January 25, 2022 11:38
edc4255
to
e751332
Compare
meiersi-da
reviewed
Jan 26, 2022
mziolekda
reviewed
Jan 26, 2022
ledger/error/src/main/scala/com/daml/error/definitions/LedgerApiErrors.scala
Outdated
Show resolved
Hide resolved
mziolekda
reviewed
Jan 26, 2022
ledger-api/grpc-definitions/com/daml/ledger/api/v1/version_service.proto
Show resolved
Hide resolved
mziolekda
approved these changes
Jan 27, 2022
azure-pipelines bot
pushed a commit
that referenced
this pull request
Feb 2, 2022
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @adriaanm-da is in charge of this release. Commit log: ``` 5390505 Remove participant-side command deduplication [DPP-848] (#12677) 85f2690 split release (#12700) ed1bf24 LF: Check activeness of cached contracts inside FetchInterface (#12698) aa2494f Speedy: check contract type after checking if they are consumed (#12691) 183f936 LF: Imporve safety of the Serialization of proto message. (#12686) b4ed15b Changed product names in the documentation (#12668) 5caaf1f Switch github urls from zip to tar.gz (#12692) 6cdda6f Metering report [DPP-817] (#12604) 716cc22 Deduplication offset period errors handled in Sandbox-on-X [DPP-872] (#12652) e4764cc Upgrade to GHC 9.0.2 (#12300) 1238e1b Update profiling documentation to Canton sandbox (#12680) f1c7e9e Drop `daml ledger navigator` in favor of `daml navigator` (#12669) 7731324 Drop profile-dir validation for sandbox-kv (#12671) 1fa095a match Foldable.foldl1's argument order to DA.List.foldl1's order (#12685) 06b63e9 update NOTICES file (#12688) 2ac76fd LF: Gracefully handle serialization error of Values beyond 2GB (#12638) 0494731 Adjust response type for script JSON API user mgmt requests (#12683) 7aabc49 Update OpenTelemetry from 0.16.0 to 1.1.0 [KVL-1256] (#12568) 117c920 Bump sandbox-on-x-it-tests size (#12681) 100c59f [JSON-API] Docs for user management endpoints (#12432) 92938d5 Moved com.daml.platform.sandbox to com.daml.ledger.sandbox in SoX (#12675) 8d5d3bd [JSON-API] User management endpoint adjustments (#12578) 54c427f Expose documentation for user-management functions in daml-script. (#12674) c1afabe [participant-state] Add earliest_offset metadata to pruned data error [kvl-1270] (#12546) ef18bf4 DEV all caps needed to exclude dev dependencies (#12679) 3d3d84f User management in daml-script over json API (#12646) 182edde [compatiblity tests] Limit the exclusion to versions that have the CommandDeduplication:Participant* tests (#12660) f08dfa3 Bump terraform (#12670) 366cd89 Add new interface serializability tests (#12666) 84cec38 Upgrade ghc-lib (#12664) d215a01 Enable user management for the Canton sandbox (#12667) bb5722c Move sandbox-classic test lib and IT tests to Sandbox-on-x (#12641) c9a65d1 update NOTICES file (#12659) 1fa7f61 ci: pin workdirs on Windows (#12645) dcbb398 Typecheck experimental primitives in damlc (#12650) 0d5443f Drop direct dependencies on system-filepath (#12658) 49f37b8 Allow defining ledger-begin and ledger-end offset conditions in ledger-api-bench-tool [DPP-836] (#12521) f1560ce Support `implements` qualified interfaces (#12644) 20836b1 Address CVE-2022-0355 alert, resolve `simple-get` to 4.0.1 (#12655) 49e6646 Clean up unstable-types test (#12648) 214951e Fix log string interpolation in AkkaExecutionSequencer (#12647) c72c27c [User management] Terminate ongoing streams when user state has changed [DPP-830] (#12437) 35eae89 Compiler: expose LF builtin ExerciseByKey (#12615) dfdb7ce Remove DA.Generics (#12634) 14f43e4 update NOTICES file (#12642) cfa8d30 [Sandbox-on-X] Ledger-side in-memory command deduplication [DPP-872] (#12596) 7567cf5 Add scala serializability checks for interfaces (#12631) 39a421e Drop unused silencer variable (#12640) 4ec336d [User management] Enforce 1k user rights limit [DPP-833] (#12558) 16a13e2 Remove redundant conformance tests from ledger-on-sql (#12639) 0610a44 daml-react: add an useUser hook (#12622) 579fb20 Reenable Canton contract id tests (#12637) 60a0f03 Hide primitiveInterface from docs (#12635) 536e493 Bump canton to latest snapshot (#12633) 613e070 Wrap client instead of runner in script test (#12630) d5ede55 Turn name collision warnings for virtual modules into errors (#12627) d5ae82d Bump cached-path-relative from 1.0.2 to 1.1.0 (#12632) f4c2862 Split release 2022-01-27 (#12624) 9e5425e update NOTICES file (#12613) fcb6124 Simplify Nix GHC derivation (#12620) 5a47223 ledger-on-memory: Do not create iterators on a mutable log. (#12626) d2216b3 Clean up unused test and unnecessary flags in ledger-on-sql tests (#12623) 345e267 create-daml-app: Use alias templates for display names (#12390) 2e3ae0d Disable ghcide snapshot on Windows (#12621) e55622e Remove a bunch of ledger-on-memory tests (#12618) f5c9a67 Remove DA.Experimental.Interfaces (#12619) 5810c25 release 2.0.0-snapshot.20220127.9042.0.4038d0a7 (#12614) f396da5 Run ledger-api-test-tool tests on ledger-on-sql with PostgreSQL (#12616) 89ce7d0 Remove conflict-checking logic from JdbcLedgerDao [DPP-808] (#12555) ``` Changelog: ``` with experimental support for non-aggregated metering reporting - [Daml Standard Library] An argument order in the default implementation of ``Foldable.foldl1`` was reversed from that of ``DA.List.foldl1``; this incompatibly changes the former to match the latter. - [HTTP-JSON] Added documentation for the new user management endpoints - [HTTP-JSON] Adjusted the response for the createUser & deleteUser endpoint to an empty object instead of "true". This was done to allow possible future extensions to the return type without applying breaking changes. - [HTTP-JSON] Made the field rights optional for the request body of the createUser endpoint. Now it is possible to create a user with just the userId (i.e. { "userId": "nice.user" }). - [Integration Kit] - ledger-api-bench-tool allow to define ledger-begin and ledger-end offset boundaries for streams. Ledger API Specification: When using user management based authorization streams will now get aborted on authenticated user's rights change. - [Daml Standard Library] The DA.Generics module has been removed. Ledger API Specification: Maximum number of user rights per user is now limited to 1000 and is added to UserManagementFeature in VersionService. getLedgerApiVersion endpoint. [daml-react] A `useUser` react hook is added to the daml-react TypeScript library. It allows for easy access to the currently logged in user of a ledger participant node for ledgers supporting user management. ``` CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.