-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.12.18 #1234
Merged
Merged
Release 0.12.18 #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have accumulated quite a few fixes and improvements in the last week so it’s time for another release.
ghost
approved these changes
May 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🎸
@cocreature i tidied up the release notes, good to go |
bitonic
approved these changes
May 20, 2019
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 21, 2020
This patch changes the call to the GitHub API that translates the release notes from markdown to HTML to use gfm instead of plain markdown. gfm is a superset of markdown that adds the following: - GitHub usernames (`@`-mentions) are turned into links to the user's profile page. - Issues and PR numbers (`#1234`) are turned into links to the corresponding issue or PR. - Existing git shas are turned into links to the corresponding commit. An example of this feature missing is the release notes for [v0.13.42](https://blog.daml.com/release-notes/0.13.42-1), where intended links such as > - Rename argument in active contract to payload. See #3826. are not rendered. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 21, 2020
This patch changes the call to the GitHub API that translates the release notes from markdown to HTML to use gfm instead of plain markdown. gfm is a superset of markdown that adds the following: - GitHub usernames (`@`-mentions) are turned into links to the user's profile page. - Issues and PR numbers (`#1234`) are turned into links to the corresponding issue or PR. - Existing git shas are turned into links to the corresponding commit. An example of this feature missing is the release notes for [v0.13.42](https://blog.daml.com/release-notes/0.13.42-1), where intended links such as > - Rename argument in active contract to payload. See #3826. are not rendered. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 21, 2020
This patch changes the call to the GitHub API that translates the release notes from markdown to HTML to use gfm instead of plain markdown. gfm is a superset of markdown that adds the following: - GitHub usernames (`@`-mentions) are turned into links to the user's profile page. - Issues and PR numbers (`#1234`) are turned into links to the corresponding issue or PR. - Existing git shas are turned into links to the corresponding commit. An example of this feature missing is the release notes for [v0.13.42](https://blog.daml.com/release-notes/0.13.42-1), where intended links such as > - Rename argument in active contract to payload. See #3826. are not rendered. CHANGELOG_BEGIN CHANGELOG_END
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have accumulated quite a few fixes and improvements in the last
week so it’s time for another release.
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.