Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-daml-app] Incorporate hub-react library for new Hub API/domains #12279

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

alexmatson-da
Copy link
Contributor

@alexmatson-da alexmatson-da commented Jan 6, 2022

This PR pulls in the @daml/hub-react UI client library to the create-daml-app template. This ensures that future apps derived from the template will work with the new Daml Hub domain ({subdomain}.daml.app), while maintaining backwards compatibility with the legacy domain ({ledgerId}.projectdabl.com), currently being phased out.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@alexmatson-da alexmatson-da force-pushed the create-daml-app-hub-api branch from 99390fb to 7fd4201 Compare January 6, 2022 17:11
@alexmatson-da alexmatson-da marked this pull request as ready for review January 6, 2022 17:11
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexmatson-da alexmatson-da enabled auto-merge (squash) January 6, 2022 17:13
@alexmatson-da alexmatson-da merged commit 2b1db54 into main Jan 6, 2022
@alexmatson-da alexmatson-da deleted the create-daml-app-hub-api branch January 6, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants