Further copyright updates #12249
Merged
Further copyright updates #12249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
requested review from
cocreature,
meiersi-da,
nickchapman-da and
remyhaemmerle-da
as code owners
garyverhaegen-da
requested review from
S11001001,
sofiafaro-da,
stefanobaghino-da and
a team
as code owners
Somewhat error-prone, so please review carefully. Reasons we need this: - Some file types are not properly handled by the script. - The only exclusion mechanism we currently have (`NO_AUTO_COPYRIGHT`) is overly coarse. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
further-copyright-updates
branch
from
20d408b to
3697390
Compare
garyverhaegen-da
force-pushed
the
further-copyright-updates
branch
from
3697390 to
a1d39e7
Compare
garyverhaegen-da
force-pushed
the
further-copyright-updates
branch
from
a1d39e7 to
37f1f15
Compare
cocreature
approved these changes
Jan 4, 2022
| @@ -1,4 +1,4 @@ | |||
| # Copyright (c) 2021 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
| # Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
why do we not hit this via automation? I don’t see a no autocopyright file here.
There was a problem hiding this comment.
We detect file types (in order to figure out what kind of comment marker to use) based on extension, and this filename does not have an extension.
| @@ -1,4 +1,4 @@ | |||
| -- Copyright (c) 2021 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
| -- Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
we should either drop the no autocopyright from this directory (not sure why it’s there in the first place) or drop all the copyright headers. Not in this PR though.
There was a problem hiding this comment.
FWIW removing the NO_AUTO_COPYRIGHT file results in the copyright header script crashing on an invalid unicode file. I believe it is intentional that the file is invalid (to test how the compiler reacts on that), and I guess it was easier to ignore the entire folder than fix the script (hence my "too coarse-grained" comment).
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2021 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
| // Copyright (c) 2022 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
why is automation missing these files?
There was a problem hiding this comment.
lf is not in the list of supported extensions.
There was a problem hiding this comment.
Can we add it? Or is that some thirdparty dep that we cannot easily change?
There was a problem hiding this comment.
I'll see what I can do. I've been reluctant to touch a script that only really annoys me once a year, but this should be simple enough. Separate PR, though.
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 4, 2022
As requested by @cocreature in #12249. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
added a commit
that referenced
this pull request
Jan 4, 2022
As requested by @cocreature in #12249. CHANGELOG_BEGIN CHANGELOG_END
azure-pipelines bot
pushed a commit
that referenced
this pull request
Jan 5, 2022
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @stefanobaghino-da is in charge of this release. Commit log: ``` d3101e0 Add Flyway validation log line (#12256) c673d1f add lf extension to copyright script (#12259) ea55ea2 Further copyright updates (#12249) 93e6164 Update ci nodes for copyright update (#12255) 4b4fbf8 [ledger-api-test-tool] - adapt the command deduplication conformance to use participant deduplication feature descriptor [kvl-1218] (#12222) 7c011cf Fix tracking of party references (#12253) cd9911b daml-lf, kvutils: Move Daml-LF `Archive` decoding to `kv-support` [KVL-1168] (#12241) d31066b Make @garyverhaegen-da skip this week's release rotation (#12252) d2e2c21 update copyright headers (#12240) 2546af3 rotate release duty after 2.0.0-snapshot.20211214.8692.0.63940872 (#12148) 0e30d46 expand CI cluster back (#12239) d6d473d update NOTICES file (#12247) a51f75d give a break to CI (#12238) 4cc4b3b update compat versions for 1.18.0 (#12068) 2141bfb DPP-769 cap internal state (#12135) e1b4c30 daml-lf / kvutils: Move Daml-LF proto conversions into kv-support [KVL-1168] (#12216) 51a1f47 update NOTICES file (#12232) 8f43c03 Add transaction statistics to completion info (#12224) dc6fdaa revert back to running latest blackduck detect 6.9.0 (#12177) 994b231 Add a test for daml start --sandbox-canton (#12223) 9102b09 [ledger-api-test-tool] - add participant deduplication feature descriptor [kvl-1218] (#12213) f847767 Avoid nix result-* symlinks on CI (#12220) 830497a Add --sandbox-canton option in daml start (#12192) d922a56 DPP-752 refactor event strategy (#12008) ba0c6c9 Set --enable-scenarios to False by default (#12156) 56baf03 Rename kv-transaction-support library [KVL-1168] (#12212) 5b142eb [ledger-api-test-tool] - use offset support feature descriptor [kvl-1218] (#12211) 0142c6a Add forM_ compat definition (#12209) 99f9776 New split release for docs tests (#12186) e182fc5 [ledger-api] - Move deduplication duration validation into the KV WriteService (#12151) 53d5578 [ledger-api] - Add command deduplication features as a feature descriptor [KVL-1218] (#12181) 040f1a9 Release attempt over 9000 (#12206) ``` Changelog: ``` ledger-api - Remove validation for duration deduplication periods, which was validating that the deduplication duration is smaller than the max deduplication duration. This is now up to the ledger to enforce. ``` CHANGELOG_BEGIN CHANGELOG_END
cocreature
pushed a commit
that referenced
this pull request
Jan 5, 2022
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @stefanobaghino-da is in charge of this release. Commit log: ``` d3101e0 Add Flyway validation log line (#12256) c673d1f add lf extension to copyright script (#12259) ea55ea2 Further copyright updates (#12249) 93e6164 Update ci nodes for copyright update (#12255) 4b4fbf8 [ledger-api-test-tool] - adapt the command deduplication conformance to use participant deduplication feature descriptor [kvl-1218] (#12222) 7c011cf Fix tracking of party references (#12253) cd9911b daml-lf, kvutils: Move Daml-LF `Archive` decoding to `kv-support` [KVL-1168] (#12241) d31066b Make @garyverhaegen-da skip this week's release rotation (#12252) d2e2c21 update copyright headers (#12240) 2546af3 rotate release duty after 2.0.0-snapshot.20211214.8692.0.63940872 (#12148) 0e30d46 expand CI cluster back (#12239) d6d473d update NOTICES file (#12247) a51f75d give a break to CI (#12238) 4cc4b3b update compat versions for 1.18.0 (#12068) 2141bfb DPP-769 cap internal state (#12135) e1b4c30 daml-lf / kvutils: Move Daml-LF proto conversions into kv-support [KVL-1168] (#12216) 51a1f47 update NOTICES file (#12232) 8f43c03 Add transaction statistics to completion info (#12224) dc6fdaa revert back to running latest blackduck detect 6.9.0 (#12177) 994b231 Add a test for daml start --sandbox-canton (#12223) 9102b09 [ledger-api-test-tool] - add participant deduplication feature descriptor [kvl-1218] (#12213) f847767 Avoid nix result-* symlinks on CI (#12220) 830497a Add --sandbox-canton option in daml start (#12192) d922a56 DPP-752 refactor event strategy (#12008) ba0c6c9 Set --enable-scenarios to False by default (#12156) 56baf03 Rename kv-transaction-support library [KVL-1168] (#12212) 5b142eb [ledger-api-test-tool] - use offset support feature descriptor [kvl-1218] (#12211) 0142c6a Add forM_ compat definition (#12209) 99f9776 New split release for docs tests (#12186) e182fc5 [ledger-api] - Move deduplication duration validation into the KV WriteService (#12151) 53d5578 [ledger-api] - Add command deduplication features as a feature descriptor [KVL-1218] (#12181) 040f1a9 Release attempt over 9000 (#12206) ``` Changelog: ``` ledger-api - Remove validation for duration deduplication periods, which was validating that the deduplication duration is smaller than the max deduplication duration. This is now up to the ledger to enforce. ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat error-prone, so please review carefully.
Reasons we need this:
NO_AUTO_COPYRIGHT)is overly coarse.
CHANGELOG_BEGIN
CHANGELOG_END