Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of deprecated components #12167

Merged
merged 8 commits into from
Dec 16, 2021
Merged

Get rid of deprecated components #12167

merged 8 commits into from
Dec 16, 2021

Conversation

stefanobaghino-da
Copy link
Contributor

Removes:

  • mentions of the Node.js bindings
  • mentions of the Scala bindings
  • usage of the Scala codegen as an SDK tool
  • Java bindings "reactive components"

changelog_begin
The Node.js bindings are no longer supported as part of the Daml SDK
The Scala bindings are no longer supported as part of the Daml SDK
The Java bindings reactive components are no longer supported as part of the Daml SDK
The daml codegen command has dropped support for Scala
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description
  • If you mean to change the status of a component, please make sure you keep the Component Status page up to date.

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@stefanobaghino-da
Get rid of deprecated components
548a6b6 
Removes:
- mentions of the Node.js bindings
- mentions of the Scala bindings
- usage of the Scala codegen as an SDK tool
- Java bindings "reactive components"

changelog_begin
The Node.js bindings are no longer supported as part of the Daml SDK
The Scala bindings are no longer supported as part of the Daml SDK
The Java bindings reactive components are no longer supported as part of the Daml SDK
The `daml codegen` command has dropped support for Scala
changelog_end
@stefanobaghino-da stefanobaghino-da requested review from cocreature and a team as code owners December 16, 2021 11:20
@stefanobaghino-da
Copy link
Contributor Author

5y3igt

@cocreature
Copy link
Contributor

I want to see non-deprecated components burn as well

@stefanobaghino-da @cocreature
Fix typo noticed by @cocreature
8831045 
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
ghost
ghost approved these changes Dec 16, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ghost
Copy link

ghost commented Dec 16, 2021

Should this be 🔥 as well: https://github.com/digital-asset/daml/blob/main/daml-assistant/daml-helper/src/DA/Daml/Helper/Main.hs#L244 ?

akshayshirahatti-da
akshayshirahatti-da approved these changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@akshayshirahatti-da akshayshirahatti-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , couple of minor comments

@stefanobaghino-da
Copy link
Contributor Author

Should this be fire as well: https://github.com/digital-asset/daml/blob/main/daml-assistant/daml-helper/src/DA/Daml/Helper/Main.hs#L244 ?

I'll remove it, thanks for making me notice that. 🙇🏻

cocreature
cocreature requested changes Dec 16, 2021
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes until we publish a standalone JAR for the scala codegen.

@stefanobaghino-da
Copy link
Contributor Author

Should this be fire as well: https://github.com/digital-asset/daml/blob/main/daml-assistant/daml-helper/src/DA/Daml/Helper/Main.hs#L244 ?

Should be addressed by 0b44000, let me know if it looks in order. 🙇🏻

@stefanobaghino-da
Copy link
Contributor Author

@oliverse-da FYI from the next snapshot (which I believe won't be cut before next year) you should use the standalone Scala codegen JAR instead of daml codegen scala.

@stefanobaghino-da stefanobaghino-da enabled auto-merge (squash) December 16, 2021 15:40
cocreature and others added 2 commits December 16, 2021 17:25
@cocreature
fix typo
73c7b14 
changelog_begin
changelog_end
@stefanobaghino-da
Fix formatting
dc467b6
@stefanobaghino-da stefanobaghino-da merged commit 42adfdc into main Dec 16, 2021
@stefanobaghino-da stefanobaghino-da deleted the ste/remove-deprecated-bindings-docs branch December 16, 2021 16:55
@oliverse-da
Copy link
Contributor

oliverse-da commented Dec 17, 2021 •
edited
Loading

@oliverse-da FYI from the next snapshot (which I believe won't be cut before next year) you should use the standalone Scala codegen JAR instead of daml codegen scala.

Thanks for the heads-up @stefanobaghino-da - this means we will use the codegen-jvm-main*.jar instead, right?

I.e. based on what I have prototyped and tested successfully here: https://github.com/DACH-NY/canton/pull/8114/files#diff-486adab54dc0e9a504950abc7f803ca7833458c1883e114101905a992480a782R426-R444

@cocreature
Copy link
Contributor

Not quite, you’ll have to adapt to com.daml.codegen-scala-main. I think the only difference is that it does not include the Java codegen and doesn’t have the scala parameter as the first positional argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayshirahatti-da akshayshirahatti-da akshayshirahatti-da approved these changes

@cocreature cocreature cocreature approved these changes

@sofiafaro-da sofiafaro-da Awaiting requested review from sofiafaro-da

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

@S11001001 S11001001 Awaiting requested review from S11001001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanobaghino-da @cocreature @oliverse-da @akshayshirahatti-da