LF: Add "requires" field to Scala Ast. #12028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #11978. Adds typechecking for this field on the interface side, and enforces that any template that implements A must implement B if A requires B. CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
requested review from
sofiafaro-da
and removed request for
cocreature
sofiafaro-da
reviewed
Dec 7, 2021
...lf/validation/src/main/scala/com/digitalasset/daml/lf/validation/iterable/ExprIterable.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Sofia Faro <sofia.faro@digitalasset.com>
azure-pipelines bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` c4d82f7 new 2.12-removal-enabled features for NonEmpty (#11933) 9e5bea1 LF: Node statistics of a transaction (#12018) 43c8641 interfaces: add up/downcast expressions in proto (#12030) 9d7eb07 LF: Add "requires" field to Scala Ast. (#12028) a159b50 Test release for split release process (attempt 3) (#12019) 1dd8131 interfaces: Add "requires" field in Haskell AST. (#12016) ef23593 update compat versions for 1.11.3 (#12012) be088c6 pipeline: fix pie failure (#12017) c493c46 Test release for split release process (attempt 2) (#12007) 8df9a42 Interface desugaring cont. (#11964) ef4ae93 Add Ledger API scala client for user management (#12000) 444b3ac Rerelease 1.11.3 (#12006) c63a2c8 Drop 1.11.3 release to allow for a retry (#12005) 505a37f Fix yaml again … (#12004) 4099dff Promote 1.11.3-snapshot.20211123.6448.0.c679b4ab to release (#11999) 00d3326 Remove source code specific to Scala 2.12 (#12003) fa88836 Fix main build after broken yaml config (#12002) 1c4151b Test release for split release process (#11992) 47ce526 update NOTICES file (#11995) ``` Changelog: ``` CHANGELOG_EN - [Scala bindings] add methods to call the user management API ``` CHANGELOG_BEGIN CHANGELOG_END
akrmn
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` c4d82f7 new 2.12-removal-enabled features for NonEmpty (#11933) 9e5bea1 LF: Node statistics of a transaction (#12018) 43c8641 interfaces: add up/downcast expressions in proto (#12030) 9d7eb07 LF: Add "requires" field to Scala Ast. (#12028) a159b50 Test release for split release process (attempt 3) (#12019) 1dd8131 interfaces: Add "requires" field in Haskell AST. (#12016) ef23593 update compat versions for 1.11.3 (#12012) be088c6 pipeline: fix pie failure (#12017) c493c46 Test release for split release process (attempt 2) (#12007) 8df9a42 Interface desugaring cont. (#11964) ef4ae93 Add Ledger API scala client for user management (#12000) 444b3ac Rerelease 1.11.3 (#12006) c63a2c8 Drop 1.11.3 release to allow for a retry (#12005) 505a37f Fix yaml again … (#12004) 4099dff Promote 1.11.3-snapshot.20211123.6448.0.c679b4ab to release (#11999) 00d3326 Remove source code specific to Scala 2.12 (#12003) fa88836 Fix main build after broken yaml config (#12002) 1c4151b Test release for split release process (#11992) 47ce526 update NOTICES file (#11995) ``` Changelog: ``` CHANGELOG_EN - [Scala bindings] add methods to call the user management API ``` CHANGELOG_BEGIN CHANGELOG_END
akrmn
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` c4d82f7 new 2.12-removal-enabled features for NonEmpty (#11933) 9e5bea1 LF: Node statistics of a transaction (#12018) 43c8641 interfaces: add up/downcast expressions in proto (#12030) 9d7eb07 LF: Add "requires" field to Scala Ast. (#12028) a159b50 Test release for split release process (attempt 3) (#12019) 1dd8131 interfaces: Add "requires" field in Haskell AST. (#12016) ef23593 update compat versions for 1.11.3 (#12012) be088c6 pipeline: fix pie failure (#12017) c493c46 Test release for split release process (attempt 2) (#12007) 8df9a42 Interface desugaring cont. (#11964) ef4ae93 Add Ledger API scala client for user management (#12000) 444b3ac Rerelease 1.11.3 (#12006) c63a2c8 Drop 1.11.3 release to allow for a retry (#12005) 505a37f Fix yaml again … (#12004) 4099dff Promote 1.11.3-snapshot.20211123.6448.0.c679b4ab to release (#11999) 00d3326 Remove source code specific to Scala 2.12 (#12003) fa88836 Fix main build after broken yaml config (#12002) 1c4151b Test release for split release process (#11992) 47ce526 update NOTICES file (#11995) ``` Changelog: ``` CHANGELOG_EN - [Scala bindings] add methods to call the user management API ``` CHANGELOG_BEGIN CHANGELOG_END
akrmn
pushed a commit
that referenced
this pull request
Dec 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` c4d82f7 new 2.12-removal-enabled features for NonEmpty (#11933) 9e5bea1 LF: Node statistics of a transaction (#12018) 43c8641 interfaces: add up/downcast expressions in proto (#12030) 9d7eb07 LF: Add "requires" field to Scala Ast. (#12028) a159b50 Test release for split release process (attempt 3) (#12019) 1dd8131 interfaces: Add "requires" field in Haskell AST. (#12016) ef23593 update compat versions for 1.11.3 (#12012) be088c6 pipeline: fix pie failure (#12017) c493c46 Test release for split release process (attempt 2) (#12007) 8df9a42 Interface desugaring cont. (#11964) ef4ae93 Add Ledger API scala client for user management (#12000) 444b3ac Rerelease 1.11.3 (#12006) c63a2c8 Drop 1.11.3 release to allow for a retry (#12005) 505a37f Fix yaml again … (#12004) 4099dff Promote 1.11.3-snapshot.20211123.6448.0.c679b4ab to release (#11999) 00d3326 Remove source code specific to Scala 2.12 (#12003) fa88836 Fix main build after broken yaml config (#12002) 1c4151b Test release for split release process (#11992) 47ce526 update NOTICES file (#11995) ``` Changelog: ``` CHANGELOG_EN - [Scala bindings] add methods to call the user management API ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines Daml Build <support@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11978. Adds typechecking for this field on the interface side,
and enforces that any template that implements A must implement B if A requires B.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.