Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign @nicholassmith-da and @gerolf-da as CODEOWNERS for language-support/java #1183

Merged
merged 1 commit into from
May 16, 2019
Merged

Assign @nicholassmith-da and @gerolf-da as CODEOWNERS for language-support/java #1183

merged 1 commit into from
May 16, 2019

Conversation

gerolf-da
Copy link
Contributor

@gerolf-da gerolf-da commented May 16, 2019 •
edited
Loading

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@gerolf-da gerolf-da requested a review from bitonic as a code owner May 16, 2019 12:19
@gerolf-da gerolf-da requested a review from a user May 16, 2019 12:19
@gerolf-da gerolf-da changed the title Assign @nicholassmith-da and @gerolf-da as CODEOWNERS for language-su… Assign @nicholassmith-da and @gerolf-da as CODEOWNERS for language-support/java May 16, 2019
ghost
ghost approved these changes May 16, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerolf-da
Copy link
Contributor Author

@nicholassmith-da: FYI

hurryabit
hurryabit suggested changes May 16, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this after the other PR regarding code owners has landed. And please do only add yourself on top of what's already there then, currently @daml/empty.

@gerolf-da gerolf-da force-pushed the codeowners-for-java branch from 84f9daf to ca616f9 Compare May 16, 2019 13:20
@gerolf-da gerolf-da requested a review from hurryabit May 16, 2019 13:20
hurryabit
hurryabit approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@mergify mergify bot merged commit c058f0a into master May 16, 2019
@mergify mergify bot deleted the codeowners-for-java branch May 16, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@bitonic bitonic Awaiting requested review from bitonic

@neil-da neil-da Awaiting requested review from neil-da

@nicholassmith-da nicholassmith-da Awaiting requested review from nicholassmith-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerolf-da @hurryabit