Expose a contract's agreement text on the Ledger API #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerolf-da
added
component/java-ecosystem
gerolf-da
requested review from
bitonic,
leo-da,
gabor-aranyossy,
rautenrieth-da and
nicholassmith-da
bitonic
suggested changes
May 15, 2019
...tor/backend/src/test/scala/com/digitalasset/navigator/backend/query/ContractFilterSpec.scala
Outdated
Show resolved
Hide resolved
gabor-aranyossy
approved these changes
May 15, 2019
rautenrieth-da
requested changes
May 15, 2019
navigator/backend/src/main/scala/com/digitalasset/navigator/json/ModelCodec.scala
Outdated
Show resolved
Hide resolved
navigator/backend/src/main/scala/com/digitalasset/navigator/graphql/GraphQLSchema.scala
Show resolved
Hide resolved
gerolf-da
force-pushed
the
1110-agreements-on-ledger-api
branch
from
d6236a9 to
4d87bd4
Compare
|
@bethaitman: I added a few lines to the release notes. Could I ask you to take a look when you have time? |
|
@bitonic: I added the integration test. I'll soon be able to remove the draft status :) |
gerolf-da
commented
May 15, 2019
gerolf-da
commented
May 15, 2019
gerolf-da
commented
May 15, 2019
bitonic
suggested changes
May 16, 2019
...uite/scala/com/digitalasset/platform/tests/integration/ledger/api/TransactionServiceIT.scala
Outdated
Show resolved
Hide resolved
bitonic
reviewed
May 16, 2019
...uite/scala/com/digitalasset/platform/tests/integration/ledger/api/TransactionServiceIT.scala
Outdated
Show resolved
Hide resolved
bitonic
approved these changes
May 16, 2019
bitonic
approved these changes
May 16, 2019
bethaitman
reviewed
May 16, 2019
bethaitman
reviewed
May 16, 2019
bethaitman
reviewed
May 16, 2019
bethaitman
reviewed
May 16, 2019
bethaitman
reviewed
May 16, 2019
gerolf-da
force-pushed
the
1110-agreements-on-ledger-api
branch
from
11a465f to
8fc1f7f
Compare
|
@rautenrieth-da: could you check the navigator changes again please? I should've fixed all your comments. |
navigator/backend/src/main/scala/com/digitalasset/navigator/json/ModelCodec.scala
Outdated
Show resolved
Hide resolved
gerolf-da
force-pushed
the
1110-agreements-on-ledger-api
branch
from
ea3d0f7 to
011dcba
Compare
Co-Authored-By: Francesco Mazzoli <f@mazzo.li>
Co-Authored-By: Beth Aitman <bethaitman@users.noreply.github.com>
gerolf-da
force-pushed
the
1110-agreements-on-ledger-api
branch
from
011dcba to
fa40588
Compare
rautenrieth-da
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agreement_textfield to theCreatedEventin Ledger API.ContractInstto theCreatedEventFixes #1110
Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.