extractor: use daml-lf transaction Value ADT instead of bespoke ADT #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-use-transaction-value-adt
- JSON object ordering now matches record field order, instead of being its reverse - Includes a new encoding for records missing labels, to a list of 2-tuples
…r-use-transaction-value-adt
- JSON date/time is just <num>s since epoch, maybe revisit
…r-use-transaction-value-adt
S11001001
commented
May 14, 2019
| Encoder[String].contramap(identity) | ||
|
|
||
| // TODO SC this matches the prior behavior of JSON-ing the dates and timestamps | ||
| // as days-since and micros-since epoch, but maybe we'd like something else? |
There was a problem hiding this comment.
cc @bitonic @remyhaemmerle-da @leo-da for JSON-pinions
There was a problem hiding this comment.
Yes, i think we should change this to use string representations, as we did with the old JSON-through-LfTypeEncoding. Feel free to change this in the next PR though.
leo-da
reviewed
May 15, 2019
daml-lf/data/src/main/scala/com/digitalasset/daml/lf/data/ImmArray.scala
Outdated
Show resolved
Hide resolved
extractor/src/main/scala/com/digitalasset/extractor/json/JsonConverters.scala
Show resolved
Hide resolved
extractor/src/main/scala/com/digitalasset/extractor/ledger/types/LedgerValue.scala
Outdated
Show resolved
Hide resolved
| @@ -269,54 +268,52 @@ object Queries { | |||
|
|
|||
| private def toFragmentNullable(valueSum: LedgerValue): Fragment = { | |||
| valueSum match { | |||
| case LedgerValue.Optional(None) => Fragment.const("NULL") | |||
| case LedgerValue.Optional(Some(innerVal)) => toFragment(innerVal) | |||
| case V.ValueOptional(None) => Fragment.const("NULL") | |||
There was a problem hiding this comment.
This can be a constant, don't know if Fragment.const is actually heavy or not.
…r-use-transaction-value-adt
…r-use-transaction-value-adt
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extractor uses its own
LedgerValueADT as a pivot from the ledger-api Value type; instead, we should recycle theValueADT fromdaml-lf/transactionlibrary. This rewrites all the codecs and things to use that ADT instead, with some behavioral changes informed by the new ADT, such as proper handling of missing record field labels.Pull Request Checklist
NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.