Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger-api-client: Generate a submission id if it's empty in the CommandClient [KVL-1104] #10926

Merged
merged 2 commits into from
Sep 20, 2021
Merged

ledger-api-client: Generate a submission id if it's empty in the CommandClient [KVL-1104] #10926

merged 2 commits into from
Sep 20, 2021

Conversation

hubert-da
Copy link
Collaborator

@hubert-da hubert-da commented Sep 17, 2021 •
edited
Loading

Replaces: #10919

It turns out that even though we enrich submission requests with the submission id if it's empty (#10882), it gets bypassed when using the CommandClient.
Therefore, we generate a submission id if it's empty in CommandClient.commandUpdaterFlow and fail fast if the submission id is empty in the CommandTracker to indicate a bug.

This change is covered by tests that started failing here: https://dev.azure.com/digitalasset/daml/_build/results?buildId=88924&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=ac0b0b0f-051f-52f7-8fb3-a7e384b0dde9&l=2461

Needs to be backported to the 1.17 release branch.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@hubert-da hubert-da mentioned this pull request Sep 17, 2021
Merged
6 tasks
fabiotudone-da
fabiotudone-da reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@fabiotudone-da fabiotudone-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. Have you considered unifying the code paths so that the submission ID is generated in only one place?
  2. Could you add a test for the new behavior in the Command Client?

@hubert-da
Copy link
Collaborator Author

@fabiotudone-da,

  1. Yes, the one here will have to stay, I believe. I can create a story for the gRPC services. However, it may still require some larger refactoring.
  2. There are at least 3 tests that cover this one (as mentioned in the description). However, the command client doesn't have unit tests at all, so I was going to create a story to add them, including the submission id generation. If you'd like, I can also do it in a separate PR that won't have to go to the release branch. I would really like to merge this one at least: Backport of #10868 and #10926 #10928

@hubert-da hubert-da merged commit fc2c87d into main Sep 20, 2021
@hubert-da hubert-da deleted the hubert-da/command-tracker/empty-submission-id branch September 20, 2021 08:00
hubert-da added a commit that referenced this pull request Sep 20, 2021
@hubert-da
Backport of #10868 and #10926 (#10928)
de3dc38 
* Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)

CHANGELOG_BEGIN
CHANGELOG_END

* Throw an exception if the submission id is empty in `CommandTracker`

CHANGELOG_BEGIN
CHANGELOG_END

* Generate a submission ID in the `CommandClient` if it's empty

CHANGELOG_BEGIN
CHANGELOG_END
@andreaslochbihler-da
Copy link
Contributor

We're now generating submission IDs in many places and I do wonder why that's needed. My preference would have been to identify a single place where this is done, i.e., either in the Ledger API command service or in the command tracker. In particular, it's not clear why we generate one in the ledger API command submission service, as everything below the command service should treat the submission ID as an opaque string without meaning that is just passed on.

This is probably not enough of an issue for the SDK 1.17 release, but something that might be worth cleaning up while we're at it.

@hubert-da hubert-da added the needs-backport Candidate fix for backporting to the latest release branch label Sep 20, 2021
@hubert-da
Copy link
Collaborator Author

The above issues will be addressed by a newly created KVL-1107.

azure-pipelines bot pushed a commit that referenced this pull request Sep 22, 2021
release 1.17.0-snapshot.20210921.7889.0.1b473c2b
f3c506d 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.

```

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da pushed a commit that referenced this pull request Sep 22, 2021
@azure-pipelines @cocreature
release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
fc153a9 
* release 1.17.0-snapshot.20210921.7889.0.1b473c2b

This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.

```

CHANGELOG_BEGIN
CHANGELOG_END

* 1.18 not 1.17

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
garyverhaegen-da added a commit that referenced this pull request Sep 22, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272
d6a228f 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da added a commit that referenced this pull request Sep 22, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272
213e587 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
cocreature pushed a commit that referenced this pull request Sep 23, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272 (#10998)
871d03b 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiotudone-da fabiotudone-da fabiotudone-da approved these changes

@oliverse-da oliverse-da Awaiting requested review from oliverse-da

@nicu-da nicu-da Awaiting requested review from nicu-da

Assignees
No one assigned
Labels
needs-backport Candidate fix for backporting to the latest release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hubert-da @andreaslochbihler-da @fabiotudone-da