Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpp 494 unit testing ha coordinator #10862

Merged
merged 11 commits into from
Sep 16, 2021
Merged

Dpp 494 unit testing ha coordinator #10862

merged 11 commits into from
Sep 16, 2021

Conversation

nmarton-da
Copy link
Contributor

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@nmarton-da nmarton-da requested review from meiersi-da and a team as code owners September 13, 2021 12:54
@rautenrieth-da rautenrieth-da self-requested a review September 15, 2021 09:21
@nmarton-da nmarton-da force-pushed the dpp-494-unit-testing-ha-coordinator branch from 0dbb4be to eecea8c Compare September 15, 2021 10:08
meiersi-da
meiersi-da reviewed Sep 15, 2021
View reviewed changes
Copy link
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmarton-da : I did not manage to completely review the HaCoordinatorSpec both because of a lack of knowledge and time. I see though that you are getting good reviews from @mziolekda and @rautenrieth-da.

I thus won't aim to complete this review. Here are the comments I've had so far. All minor, so please feel free to ignore.

...cipant-integration-api/src/test/lib/scala/platform/indexer/ha/TestDBLockStorageBackend.scala Show resolved Hide resolved
...cipant-integration-api/src/test/lib/scala/platform/indexer/ha/TestDBLockStorageBackend.scala Show resolved Hide resolved
@nmarton-da nmarton-da force-pushed the dpp-494-unit-testing-ha-coordinator branch from eecea8c to 5e05442 Compare September 15, 2021 11:57
@nmarton-da
Unit testing: HA Coordinator
97de6d0 
* Preparation: switch to fix-thread-pool in AkkaBeforeAndAfterAll to have more stable test runtimes

CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Preparation: switch to timer from akka-pattern and Scheduler in waiti…
bfdce57 
…ng-futures, for higher precision timing

CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Preparation: prevent race in PollingChecker (corner-case uncovered vi…
c480cca 
…a sustained testing)

CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Preparation - HaCoordinator refactorings: switch from DataSource to c…
ff88363 
…onnection factory functions to clean dependencies, fixing some typos

CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Add test infrastructure for locking
617a810 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Reuse StorageBackendTestsDBLock to test TestDBLockStorageBackend
7f111ec 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Add unit test suite for HaCoordinator
3bd05fc 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Fix random generation to respect scala 2.12
9ffa065 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Adds test cases for graceful-shutdown during initialization
2ec40ca 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Minor changes based on review
10e5683 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da
Some comment rewording based on review
5cd42b9 
CHANGELOG_BEGIN
CHANGELOG_END
@nmarton-da nmarton-da force-pushed the dpp-494-unit-testing-ha-coordinator branch from 5e05442 to 5cd42b9 Compare September 15, 2021 19:32
@cocreature
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@mziolekda mziolekda merged commit 308f938 into main Sep 16, 2021
@mziolekda mziolekda deleted the dpp-494-unit-testing-ha-coordinator branch September 16, 2021 15:08
azure-pipelines bot pushed a commit that referenced this pull request Sep 22, 2021
release 1.17.0-snapshot.20210921.7889.0.1b473c2b
f3c506d 
This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.

```

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da pushed a commit that referenced this pull request Sep 22, 2021
@azure-pipelines @cocreature
release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
fc153a9 
* release 1.17.0-snapshot.20210921.7889.0.1b473c2b

This PR has been created by a script, which is not very smart
and does not have all the context. Please do double-check that
the version prefix is correct before merging.

@garyverhaegen-da is in charge of this release.

Commit log:
```
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```
Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.

```

CHANGELOG_BEGIN
CHANGELOG_END

* 1.18 not 1.17

changelog_begin
changelog_end

Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
garyverhaegen-da added a commit that referenced this pull request Sep 22, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272
d6a228f 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
garyverhaegen-da added a commit that referenced this pull request Sep 22, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272
213e587 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
cocreature pushed a commit that referenced this pull request Sep 23, 2021
@garyverhaegen-da
release 1.18.0-snapshot.20210922.7908.0.ced4a272 (#10998)
871d03b 
@garyverhaegen-da is in charge of this release.

This supersedes the failed #10971 and #10993.

Commit log:
```
ced4a27 Include concurrency info in output (#10970)
a0b6800 Limit maximum number of concurrent tests (#10969)
a0fe0f6 release 1.18.0-snapshot.20210921.7889.1.1b473c2b (#10993)
58c82b6 LF: reduce usage of NodeCreate.coinst (#10988)
f56ce2a kvutils: Add structured error data to the error metadata [KVL-1032] (#10964)
3f4dbf6 interfaces: Syntax highlighting for interfaces (#10987)
d52a285 interface: Add test for conversion functions (#10991)
28b8d9a bump dotnet (#10979)
fe10ffb Use ValueEnricher in ScenarioRunner. (#10897)
bdad7d5 Upgrade Java on Windows (#10965)
34390f7 interfaces: Implemented conversions, added test. (#10982)
7740b60 participant-integration-api: Improve the CommandConfiguration docs. (#10978)
04f322e Bump resources for daml-ledger tests (#10984)
6d9922e Retry upsert of command deduplication on oracle and h2 [DPP-609] (#10976)
eb4f1b2 LF: Move lookup tests out of EngineTest (#10973)
99836d2 Handle fetchByKey callback correctly in scenario runner (#10980)
23e6a2d Improve feedback from failing match in AuthMatchers (#10981)
e299103 [Short] Small test tool's CLI parser refactor (#10923)
fc153a9 release 1.18.0-snapshot.20210921.7889.0.1b473c2b (#10971)
1b473c2 Switch trigger service time provider default to wall-clock time (#10967)
4acf34b Add conversions from/to interfaces in Daml parser (#10954)
d50df11 interface: Add to/from interface in scala ast (#10960)
9f88e09 Drop jdk8 override (#10963)
e0587bc Add a bit of detail to RegisteredTemplates documentation, motivated by: (#10962)
cebe6ed Refactor safetyStep in the simplifier. (#10948)
ac192fc interfaces: Add to/from interface in Haskell typechecker (#10951)
4b4d7a3 Remove update normalizer which was too aggresive (#10925)
66e1098 Add tests for the `CompletionFromTransaction` converter [KVL-1104] (#10885)
724e50d interfaces: Add to/from interface in Haskell AST (#10945)
9a8d55a Change slack link to discuss wiki. Fixes #10946 (#10947)
8b3b033 LF: Test preprocessor resuming (#10936)
2edfc06 ifaces: name collision, typecheck fetch/exercise (#10896)
5dc15c6 LF: rename language Interface to PackageInterface (#10938)
054c6ab Upgrade canton to a more recent version (#10944)
b8533d5 [JSON-API] Production/HA documentation. (#10903)
a331762 Clarify `CommandTracker` [KVL-1104] (#10943)
5244643 Changes to increase timeout and remove assertions around mock CommandSubmissionServiceImpl (#10942)
6cc42ee rotate release duty after 1.17.0-snapshot.20210915.7832.0.38227a8e (#10892)
88ef05e sandbox-classic: Only allow `--max-parallel-submissions` here. (#10941)
ac02dbd LF: Exhaustive test for valueTranslator. (#10927)
409c0b4 interfaces: Add to/from_interface in proto (#10937)
02c8a9d Split CommonStorageBackend (#10871)
dc71a6a update NOTICES file (#10932)
0ba54a4 Add a missing test case to the `CommandTrackerFlowTest` (#10939)
855ecdf [DPP-572] Add ledger API test case for verifying conformance to `--min-tls-version` flag. (#10898)
3e13e3d Switch to stable urls in scoop python manifest (#10933)
fc2c87d ledger-api-client: Generate a submission id if it's empty in the `CommandClient` [KVL-1104] (#10926)
04d8f75 Clean up sandbox-on-x conformance tests. (#10766)
b4541b5 Logging delay of submitted commands (#10912)
b8e21d8 Fix takeFilter for the test StreamConsumer  (#10918)
906368d LF: exhaustive test for CommandPreprocessor (#10914)
61d214e Add fetch, exercise implementations for interfaces in speedy. (#10911)
d01f8e1 Fix flaky ApiConfigManagementServiceSpec test (#10922)
50291ed interfaces: scala typechecker implementation (#10867)
cac8391 Bump ghc-lib to include daml interfaces parser (#10747)
b6a6bf7 [Ledger API error codes] Extracted common errors and groups [DPP-607] (#10890)
308f938 Dpp 494 unit testing ha coordinator (#10862)
30f74ad Mark Extractor's VeryLargeArchiveSpec test as flaky (#10916)
9582e01 LF: Refactor PreprocessorSpec test (#10909)
9b0fa29 Separate exercise & fetch for interfaces from templates (#10908)
f4adee9 Add conformance test for command deduplication using the CommandService [KVL-1099] (#10883)
8a39118 Rename Completion.deduplication_time to deduplication_duration [KVL-1057] (#10900)
8e22bb6 Drop ContractId typeparameter from Value (#10827)
4543705 Drop cocreature as a codeowner from runtime things (#10906)
e6e8147 Release 1.17.0 RC from second to last commit (#10904)
f08ac5f Desugar interface implements declarations (#10895)
b5648c0 Make `CommandTracker` distinguish submissions of the same command using `submissionId` [KVL-1104] (#10868)
```

Changelog:
```
[Triggers Service] The service now starts by default using wall-clock time instead
of static time. If you want to run using static time, you need to do so explicitly
using the new '-s' or '--static-time' CLI option. If you were already using '-w'
or '--wall-clock-time' the flag has no effect. It's anyway safe to leave it there.
Sandbox: Add CLI flag `--min-tls-version` to select minimum enabled TLS version for participant server.
```

CHANGELOG_BEGIN
CHANGELOG_END
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautenrieth-da rautenrieth-da rautenrieth-da approved these changes

@meiersi-da meiersi-da meiersi-da left review comments

@mziolekda mziolekda mziolekda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nmarton-da @cocreature @meiersi-da @mziolekda @rautenrieth-da