[JSON-API] vanilla oracle_perf ci job #10688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayshirahatti-da
changed the title
akshayshirahatti-da
force-pushed
the
oracle_perf_ci
branch
from
559168a to
da2f5af
Compare
akshayshirahatti-da
force-pushed
the
oracle_perf_ci
branch
6 times, most recently
from
a1a2169 to
16ebb7f
Compare
changelog_begin changelog_end
akshayshirahatti-da
force-pushed
the
oracle_perf_ci
branch
from
16ebb7f to
963eee8
Compare
akshayshirahatti-da
force-pushed
the
oracle_perf_ci
branch
from
fa89e77 to
e241df7
Compare
akshayshirahatti-da
requested review from
cocreature,
garyverhaegen-da,
S11001001 and
stefanobaghino-da
as code owners
|
|
||
| # dont want to wait forever to test connection , 15m is more than sufficient here. | ||
| declare -fxr testConnection | ||
| timeout 15m bash -c 'until testConnection; do echo "Could not connect to Oracle, trying again..." ; sleep 1 ; done' |
There was a problem hiding this comment.
AFAICT timeout is not a Bash builtin, so may be worth adding to dev-env to get reproducible behaviour across platforms.
|
|
||
| bazel build //ledger-service/http-json-perf/... | ||
| DAR="${PWD}/bazel-bin/ledger-service/http-json-perf/LargeAcs.dar" | ||
| JWT="eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJodHRwczovL2RhbWwuY29tL2xlZGdlci1hcGkiOnsibGVkZ2VySWQiOiJNeUxlZGdlciIsImFwcGxpY2F0aW9uSWQiOiJmb29iYXIiLCJhY3RBcyI6WyJBbGljZSJdfX0.VdDI96mw5hrfM5ZNxLyetSVwcD7XtLT4dIdHIOa9lcU" |
There was a problem hiding this comment.
Would be nice to put (in a comment, perhaps) what that JWT decodes to, to save people a round trip to jwt.io.
ci/cron/daily-compat.yml
Outdated
| fetchByQuery \ | ||
| " | ||
|
|
||
| START=$(git log -n1 --format=%cd --date=format:%Y%m%d).$(git rev-list --count HEAD).$(Build.BuildId).$(git log -n1 --format=%h --abbrev=8) |
There was a problem hiding this comment.
START feels like a bit of a weird name for a variable that does not include the current time.
There was a problem hiding this comment.
renamed to METADATA
ci/cron/daily-compat.yml
Outdated
| export NUM_READERS=100 # 100 users in parallel. | ||
|
|
||
| for CASE in $TEST_CASES; do | ||
| RUN_MODE=${CASE} USE_DEFAULT_USER=true RETAIN_DATA=true bazel run //ledger-service/http-json-perf:http-json-perf-binary-ee -- \ |
There was a problem hiding this comment.
Suggested change
| RUN_MODE=${CASE} USE_DEFAULT_USER=true RETAIN_DATA=true bazel run //ledger-service/http-json-perf:http-json-perf-binary-ee -- \ | |
| RUN_MODE=${CASE} \ | |
| USE_DEFAULT_USER=true \ | |
| RETAIN_DATA=true \ | |
| bazel run //ledger-service/http-json-perf:http-json-perf-binary-ee -- \ |
ci/cron/daily-compat.yml
Outdated
| --query-store-index=oracle | ||
| done | ||
|
|
||
| GZIP=-9 tar -zcvf ${OUT}.tgz ${OUT}_* |
There was a problem hiding this comment.
Do we need to be verbose here?
There was a problem hiding this comment.
Also ${OUT}_* looks like a list of files. I personally like my tar files to be contained in a folder; could you maybe do --reports=${OUT}/${CASE} instead of ${OUT}_${CASE}?
garyverhaegen-da
approved these changes
Sep 1, 2021
There was a problem hiding this comment.
Looks good, thanks. I left one minor suggestion on the Scala code and I have one doubt regarding the oracle container (maybe @garyverhaegen-da knows about it).
...http-json-perf/src/main/scala/com/daml/http/perf/scenario/OracleMultiUserQueryScenario.scala
Outdated
Show resolved
Hide resolved
cocreature
approved these changes
Sep 2, 2021
| eval "$(dev-env/bin/dade assist)" | ||
| source $(bash_lib) | ||
|
|
||
| docker login --username "$DOCKER_LOGIN" --password "$DOCKER_PASSWORD" |
There was a problem hiding this comment.
doesn’t have to be in this PR but I think we should factor out the logic here into a bash script so we can share it between this job and the other one.
|
work done as part of #10155 |
azure-pipelines bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` 35a853f Async logging for http-json-perf tests and publish logs as a pipeline artifact (#10803) a349217 get oracle perf test output (#10800) 5f448f2 Cleanup DataSource initialization (#10794) 0e250d0 Fix parallel ingestion initialization (#10797) b8bd5e6 interface PoC: protobuf definitions (#10796) a1da025 FreePort draw from outside ephemeral port range (#10774) 945a86c Fix a race in a test of the RecoveringIndexer (#10792) 4093bbd fix macOS Bazel cache (#10795) ed99fe5 ParticipantPruningIT added events for canton safe-pruning and multi-node synchronization (#10775) 5b28aef Deprecate kvutils rejections generated only by participant state v1 [KVL-1090] (#10791) 116d6a5 DPP-577 Use BIGINT instead of TIMESTAMP (#10761) cdf4bf1 Check compatibility of timestamps (#10793) 098a08c Add Moisés to release rotation (#10789) 7ae199f Follow-up to h2 storage backend user/password in url: Review feedback switch to regex and move to pure function (#10541) a5999ab remove dead code (#10765) 4b7391b LedgerApiTestTool prints skipped (excluded) tests (#10726) a0f0fb3 [DPP-418] Enable outstanding test case for private key decryption (#10778) d750666 Do not drop details when converting between gRPC `Status` classes [KVL-1084] (#10745) 5ec9a23 Fix link to the gRPC health checks in the driver for PostgreSQL docs (#10779) 8538fe9 HA protected ledger initialization for append only schema [DPP-551] (#10705) 23b0fe7 Fix exclusions for command service tests (#10777) c4e0a75 LF: drop ad-hoc ImmArray builders (#10763) 303ba90 participant-state: Re-enable integration test for command deduplication [KVL-1089] (#10751) 793253c bump cleanup threshold (#10771) 4d67684 Fix flaky DBLock tests (#10770) 7515871 Fix exclusions for command dedup in compat tests (#10767) 50fecfb Wrap missing label names in quotes (#10749) b1c6e87 fix claims check in auth middleware (#10768) 5595d55 [JSON-API] Use the token from incoming requests to update the package list (#10602) dbafea0 Add unit tests for DBLockStorageBackend [DPP-495] (#10746) e5a6d70 Added buffer size metrics for getTransactions/getTransactionTrees (#10744) f76c868 update NOTICES file (#10762) bb908d0 Create a link to party management service in main Ledger API page. (#10138) e45d852 Fixes participant to do retries on startup as waiting for DB connectivity (#10759) f68a129 Report some oracle_json_perf numbers on slack (#10754) 7270ee3 Handle dynamic port in auth middleware client (trigger service) (#10755) ff1308e [Docs] Add info on logs on Kubernetes & metrics in the ops section (#10525) d267390 Update buf image [kvl-1049] (#10752) d2180cf Update exclusion for command deduplication to include full version range (#10750) 41881ba Command dedup: migrate kvutils to use v2 services [KVL-1049] (#10679) 4525b8c [JSON-API] vanilla oracle_perf ci job (#10688) 16df8a5 [Short] Remove unused code (#10719) b28afcf [DPP-438] Update docs on metrics that no longer use <party_name> in their name (#10728) 0662025 Clarify what the `buf` image is and how it should be used (#10741) 9071a05 sandbox-classic: Reintroduce SqlLedger tests for the mutable index. (#10722) f576cdf fix flaky test in RecoveringIndexer (#9619) f6a75b4 ledger-api-common: Do not mock final classes. (#10733) e9c8af5 Bump ghc-lib to include dropped parsing code for generic templates (#10735) 862a290 rotate release duty after 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10731) 12cb92b update compat versions for 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10737) 73c0de8 [DPP-578] Temporarily disable flaky test - Mockito plugin issue (#10734) 963bcb1 release 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10730) c11323d LF: Refactor engine test reinterpret (#10724) a995fa3 [DPP-574] Update docs about TLS: encrypted private key (#10727) 66970b7 Not sharing the absolute Deadline object. (#10713) c6c304b Improve script error on invalid script identifier format (#10702) b748fd6 Support TLS in Daml Helper --json-api requests (#10709) ``` Changelog: ``` kvutils - protobuf rejections generated by the participant state v1 API are deprecated (Inconsistent, Disputed, ResourcesExhausted, PartyNotKnownOnLedger) [Docs] Fixed link to the gRPC health checks in the driver for PostgreSQL docs participant-state: Emit completions (CommandRejected) for duplicate commands when using pre-execution - Fix a bug in the auth middleware where insufficient credentials could still give access to list of running triggers. - [JSON API] The cli option `--access-token-file` is now deprecated. It is not needed anymore and you can safely remove it. Reason is that the operations which prior required a token at startup are now done on demand using the token of the incoming request. - [Docs] Information was added in the `Operating Daml` section on how to aggregate logs on Kubernetes in conjuction with Daml services & what options exists for exporting metrics from daml services (not Kubernetes specific) participant-state: - Migrate to use only v2 Read/Write Services. This includes the use of new models for rejections/updates/submission results. - Calculate deduplicate until for committer side deduplication based on the submitter given deduplication period - if using the deprecated deduplicateUntil then just set the given timestamp - if using duration then calculate the new deduplicateUntil by using the formula (submissionTime + deduplicationDuration + minSkew) - if using offset deduplication then calculate deduplicateUntil by using the formula (submissionTime + maxDeduplicationDuration + minSkew) - if the deduplication period is not set then we don't set deduplicateUntil - Emit completions with status `ALREADY_EXISTS` for duplicate commands - [Java Bindings] DamlLedgerClient.Builder allows to set a timeout for command using `withTimeout`. - [Daml Assistant] The `daml ledger` commands now accepts `--tls` in combination with `--json-api` to access a JSON API behind a TLS reverse proxy. ``` CHANGELOG_BEGIN CHANGELOG_END
moisesackerman-da
pushed a commit
that referenced
this pull request
Sep 8, 2021
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @akrmn is in charge of this release. Commit log: ``` 35a853f Async logging for http-json-perf tests and publish logs as a pipeline artifact (#10803) a349217 get oracle perf test output (#10800) 5f448f2 Cleanup DataSource initialization (#10794) 0e250d0 Fix parallel ingestion initialization (#10797) b8bd5e6 interface PoC: protobuf definitions (#10796) a1da025 FreePort draw from outside ephemeral port range (#10774) 945a86c Fix a race in a test of the RecoveringIndexer (#10792) 4093bbd fix macOS Bazel cache (#10795) ed99fe5 ParticipantPruningIT added events for canton safe-pruning and multi-node synchronization (#10775) 5b28aef Deprecate kvutils rejections generated only by participant state v1 [KVL-1090] (#10791) 116d6a5 DPP-577 Use BIGINT instead of TIMESTAMP (#10761) cdf4bf1 Check compatibility of timestamps (#10793) 098a08c Add Moisés to release rotation (#10789) 7ae199f Follow-up to h2 storage backend user/password in url: Review feedback switch to regex and move to pure function (#10541) a5999ab remove dead code (#10765) 4b7391b LedgerApiTestTool prints skipped (excluded) tests (#10726) a0f0fb3 [DPP-418] Enable outstanding test case for private key decryption (#10778) d750666 Do not drop details when converting between gRPC `Status` classes [KVL-1084] (#10745) 5ec9a23 Fix link to the gRPC health checks in the driver for PostgreSQL docs (#10779) 8538fe9 HA protected ledger initialization for append only schema [DPP-551] (#10705) 23b0fe7 Fix exclusions for command service tests (#10777) c4e0a75 LF: drop ad-hoc ImmArray builders (#10763) 303ba90 participant-state: Re-enable integration test for command deduplication [KVL-1089] (#10751) 793253c bump cleanup threshold (#10771) 4d67684 Fix flaky DBLock tests (#10770) 7515871 Fix exclusions for command dedup in compat tests (#10767) 50fecfb Wrap missing label names in quotes (#10749) b1c6e87 fix claims check in auth middleware (#10768) 5595d55 [JSON-API] Use the token from incoming requests to update the package list (#10602) dbafea0 Add unit tests for DBLockStorageBackend [DPP-495] (#10746) e5a6d70 Added buffer size metrics for getTransactions/getTransactionTrees (#10744) f76c868 update NOTICES file (#10762) bb908d0 Create a link to party management service in main Ledger API page. (#10138) e45d852 Fixes participant to do retries on startup as waiting for DB connectivity (#10759) f68a129 Report some oracle_json_perf numbers on slack (#10754) 7270ee3 Handle dynamic port in auth middleware client (trigger service) (#10755) ff1308e [Docs] Add info on logs on Kubernetes & metrics in the ops section (#10525) d267390 Update buf image [kvl-1049] (#10752) d2180cf Update exclusion for command deduplication to include full version range (#10750) 41881ba Command dedup: migrate kvutils to use v2 services [KVL-1049] (#10679) 4525b8c [JSON-API] vanilla oracle_perf ci job (#10688) 16df8a5 [Short] Remove unused code (#10719) b28afcf [DPP-438] Update docs on metrics that no longer use <party_name> in their name (#10728) 0662025 Clarify what the `buf` image is and how it should be used (#10741) 9071a05 sandbox-classic: Reintroduce SqlLedger tests for the mutable index. (#10722) f576cdf fix flaky test in RecoveringIndexer (#9619) f6a75b4 ledger-api-common: Do not mock final classes. (#10733) e9c8af5 Bump ghc-lib to include dropped parsing code for generic templates (#10735) 862a290 rotate release duty after 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10731) 12cb92b update compat versions for 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10737) 73c0de8 [DPP-578] Temporarily disable flaky test - Mockito plugin issue (#10734) 963bcb1 release 1.17.0-snapshot.20210831.7702.0.f058c2f1 (#10730) c11323d LF: Refactor engine test reinterpret (#10724) a995fa3 [DPP-574] Update docs about TLS: encrypted private key (#10727) 66970b7 Not sharing the absolute Deadline object. (#10713) c6c304b Improve script error on invalid script identifier format (#10702) b748fd6 Support TLS in Daml Helper --json-api requests (#10709) ``` Changelog: ``` kvutils - protobuf rejections generated by the participant state v1 API are deprecated (Inconsistent, Disputed, ResourcesExhausted, PartyNotKnownOnLedger) [Docs] Fixed link to the gRPC health checks in the driver for PostgreSQL docs participant-state: Emit completions (CommandRejected) for duplicate commands when using pre-execution - Fix a bug in the auth middleware where insufficient credentials could still give access to list of running triggers. - [JSON API] The cli option `--access-token-file` is now deprecated. It is not needed anymore and you can safely remove it. Reason is that the operations which prior required a token at startup are now done on demand using the token of the incoming request. - [Docs] Information was added in the `Operating Daml` section on how to aggregate logs on Kubernetes in conjuction with Daml services & what options exists for exporting metrics from daml services (not Kubernetes specific) participant-state: - Migrate to use only v2 Read/Write Services. This includes the use of new models for rejections/updates/submission results. - Calculate deduplicate until for committer side deduplication based on the submitter given deduplication period - if using the deprecated deduplicateUntil then just set the given timestamp - if using duration then calculate the new deduplicateUntil by using the formula (submissionTime + deduplicationDuration + minSkew) - if using offset deduplication then calculate deduplicateUntil by using the formula (submissionTime + maxDeduplicationDuration + minSkew) - if the deduplication period is not set then we don't set deduplicateUntil - Emit completions with status `ALREADY_EXISTS` for duplicate commands - [Java Bindings] DamlLedgerClient.Builder allows to set a timeout for command using `withTimeout`. - [Daml Assistant] The `daml ledger` commands now accepts `--tls` in combination with `--json-api` to access a JSON API behind a TLS reverse proxy. ``` CHANGELOG_BEGIN CHANGELOG_END Co-authored-by: Azure Pipelines DAML Build <support@digitalasset.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a perf oracle job , which runs the multi user scenarios to write data and run fetch by key and payload search idx based queries. Running higher number of queries post search idx changes by Stephen
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.