daml-lf/data: Optionally truncate party names in structured logs. [KVL-996] #10163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The party name can grow quite long, so we offer ledger implementors the opportunity to truncate it in structured log output. Unfortunately, because we use Logback through the global `LoggerFactory`, there is no place to inject logging configuration. This means we also need to use global, mutable state to configure logging output. I have added a `LoggingConfiguration` class+object in Daml-LF Data, which may not be the best place, but I can't think of a better one right now. I suggest we leave it there until it has reason to grow, at which point we may want to move it. CHANGELOG_BEGIN CHANGELOG_END
Invalid input should not break the request at this point. No assertions.
This avoids the transitive dependency issue most of the time.
Again, reduces the need for transitively depending on _logging-entries_.
ghost
requested review from
aherrmann-da,
cocreature,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda,
nmarton-da,
rautenrieth-da,
remyhaemmerle-da,
S11001001,
stefanobaghino-da and
tudor-da
as code owners
oliverse-da
approved these changes
Jul 1, 2021
stefanobaghino-da
approved these changes
Jul 1, 2021
miklos-da
approved these changes
Jul 1, 2021
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The party name can grow quite long, so we offer ledger implementors the opportunity to truncate it in structured log output.
Unfortunately, because we use Logback through the global
LoggerFactory, there is no place to inject logging configuration. This means we also need to use global, mutable state to configure logging output. I have added aLoggingConfigurationclass+object in Daml-LF Data, which may not be the best place, but I can't think of a better one right now. I suggest we leave it there until it has reason to grow, at which point we may want to move it.I moved the logging implicits to a new package to reduce the number of explicit transitive dependencies.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.