daml-lf/data: Add a conversion from Ref.Identifier to LoggingValue. [KVL-996] #10157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am getting quite tired of (Bazel + Scala)'s attitude to transitive dependencies. CHANGELOG_BEGIN CHANGELOG_END
ghost
requested review from
aherrmann-da,
cocreature,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda,
nmarton-da,
rautenrieth-da,
remyhaemmerle-da,
S11001001,
stefanobaghino-da and
tudor-da
as code owners
S11001001
approved these changes
Jun 30, 2021
remyhaemmerle-da
approved these changes
Jun 30, 2021
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting quite tired of (Bazel + Scala)'s attitude to transitive dependencies.
This is kind of a meaningless change, but the purpose is to get the infrastructure in place so I can add a custom logging value for parties. @oliverse-da is interested in truncating party name length in logs for expediency, and I figured adding logging for identifiers is quite close so will get most of the teething problems out of the way.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.