LF: Structure Errors. #9974

remyhaemmerle-da · 2021-06-11T15:26:18Z

TODOS:

On ContractNotFound

            // We crash here because:
            //  1. You cannot construct a cid yourself in scenarios or
            //     daml script
            //  2. Contract id fetch failures because a contract was
            //     archived or what not are turned into more specific
            //     errors so we never produce ContractNotFound

On WronglyTypedContract LF: Clean Interpretation Error #10145

            //   (MK) This isn’t actually true. You can easily
            //   coerceContractId your way into this error. Not for
            //   this PR though.

On Pretty LF: drop PartialTransaction argument from Speedy err pretty printer #10470

    //  (MK) I’m not convinced the partial transaction here provides any real value.
    //  Afaict the only thing we use it for is to produce slightly different error
    //  if a contract is inactive due to a recursive exercise. We don’t do that in
    //  the scenario service however and I’ve never heard a request for it so I
    //  have a hard time believing that it is really useful here.

Check the error send by IdeLedgerClient. See if we can use only scenario.Error and not SError. (See Scenario: move Scenario Error Throwable to scenario package #10075)
Add an test for wrongly type contract with daml script
See LF: Move Speedy Interpretation Error to transaction package #10091 and WronglyTypedContractId.daml
try to give more context about missing package, for instance changing the type of MissingPackage to something like:
MissingPackage(packageIds: Set[PackageId], cultprit: Set[Ref.Identifier]) (See LF: add context in LookupError #10314 and LF: Add context in missing package errors #10418)

The text was updated successfully, but these errors were encountered:

remyhaemmerle-da · 2021-06-11T15:28:54Z

cc @daravep

This PR is part of the effort to improve engine Errors. Here we classify all the errors the engine can report in 4 categories: - Errors happening during package loading - Error happening during command/transaction preprocessing - Error happening during interpretation - Error happening during transaction validation part of #9974 CHANGELOG_BEGIN CHANGELOG_END

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

part of #9974 CHANGELOG_BEGIN CHANGELOG_END

part of #9974 CHANGELOG_BEGIN CHANGELOG_END Update ledger/participant-integration-api/src/main/scala/platform/store/ErrorCause.scala Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Update ledger/participant-integration-api/src/main/scala/platform/store/ErrorCause.scala Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> Address Moritz's review cosmetic

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

explaining the origining of missing package. This is part of #9974 CHANGELOG_BEGIN CHANGELOG_END

part of #9974 - rename `msg` field to `message` - drop `engine.Error.Validation.Generic` - rename argument `where` to `location` - Builtin set the `dependsOnTime` before throwing the callback `SResultNeedTime` CHANGELOG_BEGIN CHANGELOG_END

part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da self-assigned this Jun 11, 2021

remyhaemmerle-da mentioned this issue Jun 11, 2021

LF: Factorize the logic for Ast lookup #9871

Merged

6 tasks

remyhaemmerle-da mentioned this issue Jun 11, 2021

LF: Structure Engine Errors. #9971

Merged

6 tasks

remyhaemmerle-da added the component/daml-lf DAML-LF label Jun 11, 2021

remyhaemmerle-da added this to the Maintenance milestone Jun 11, 2021

remyhaemmerle-da added a commit that referenced this issue Jun 14, 2021

LF: Structure package loading errors

0c7aae5

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Jun 14, 2021

LF: Structure package loading errors #9980

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jun 15, 2021

LF: Structure package loading errors

18379c1

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 15, 2021

LF: Structure package loading errors (#9980)

af144e8

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 15, 2021

LF: Structure Preprocessing Errors

e6bbc24

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Jun 15, 2021

LF: Structure Preprocessing Errors #10013

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jun 15, 2021

LF: Structure Preprocessing Errors

de011f7

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 15, 2021

LF: Structure Preprocessing Errors

820afdb

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 17, 2021

LF: Structure Preprocessing Errors (#10013)

3532460

part of #9974. CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Jun 17, 2021

LF: Clean up of Errors #10052

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jun 17, 2021

LF: Finish ckean up of Engine Errors

ee01f6d

part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

0402069

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package #10091

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

25eadbe

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

ac70a50

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

98f9cc8

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

92dde70

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 23, 2021

LF: Move Speedy Interpretation Error to transaction package

473bb64

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 24, 2021

LF: Move Speedy Interpretation Error to transaction package

30cddb5

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 24, 2021

LF: Move Speedy Interpretation Error to transaction package

5bdeb76

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jun 24, 2021

LF: Move Speedy Interpretation Error to transaction package

42adee1

to be accessible from any package part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Jun 24, 2021

Scenario: move Scenario Error Throwable to scenario package #10075

Merged

6 tasks

remyhaemmerle-da linked a pull request Jul 27, 2021 that will close this issue

LF: Add context in missing package errors #10418

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jul 27, 2021

LF: Add context in missing package errors

b7f7047

explaining the origining of missing package. This is part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jul 27, 2021

LF: Add context in missing package errors

7b0fa1a

explaining the origining of missing package. This is part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da added a commit that referenced this issue Jul 28, 2021

LF: Add context in missing package errors

0bd1965

explaining the origining of missing package. This is part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da removed a link to a pull request Jul 28, 2021

LF: avoid usage of GlobalKey.key in engine error #10158

Closed

6 tasks

remyhaemmerle-da linked a pull request Jul 28, 2021 that will close this issue

LF: change type from Try to Either in archive module #10277

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Jul 28, 2021

LF: Add context in missing package errors (#10418)

73290c2

explaining the origining of missing package. This is part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da mentioned this issue Aug 4, 2021

LF: Log internal errors #10471

Merged

6 tasks

remyhaemmerle-da added a commit that referenced this issue Aug 4, 2021

LF: Log internal errors (#10471)

dc47b10

part of #9974 CHANGELOG_BEGIN CHANGELOG_END

remyhaemmerle-da closed this as completed Aug 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LF: Structure Errors. #9974

LF: Structure Errors. #9974

remyhaemmerle-da commented Jun 11, 2021 •

edited

Loading

remyhaemmerle-da commented Jun 11, 2021

LF: Structure Errors. #9974

LF: Structure Errors. #9974

Comments

remyhaemmerle-da commented Jun 11, 2021 • edited Loading

remyhaemmerle-da commented Jun 11, 2021

remyhaemmerle-da commented Jun 11, 2021 •

edited

Loading