Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend scala serializability check for interfaces #12482

Closed
cocreature opened this issue Jan 19, 2022 · 0 comments · Fixed by #12631
Closed

Extend scala serializability check for interfaces #12482

cocreature opened this issue Jan 19, 2022 · 0 comments · Fixed by #12631
Assignees
@akrmn
Labels
language Language team work
Milestone
Daml Interfaces

Comments

@cocreature
Copy link
Contributor

Needs to check choice argument & result types.
@cocreature cocreature added this to the Daml Interfaces milestone Jan 19, 2022
cocreature added a commit that referenced this issue Jan 19, 2022
@cocreature
Add missing serializability checks for interfaces
96af6f2 
The checks for argument & result type were missing before. I openey
#12482 to do the same fix
on the Scala side.

changelog_begin
changelog_end
@cocreature cocreature mentioned this issue Jan 19, 2022
Merged
7 tasks
cocreature added a commit that referenced this issue Jan 19, 2022
@cocreature
Add missing serializability checks for interfaces (#12483)
681f8fc 
* Add missing serializability checks for interfaces

The checks for argument & result type were missing before. I openey
#12482 to do the same fix
on the Scala side.

fixes #12475 

changelog_begin
changelog_end

* .

changelog_begin
changelog_end
@cocreature cocreature added the language Language team work label Jan 27, 2022
@akrmn akrmn linked a pull request Jan 27, 2022 that will close this issue
Add scala serializability checks for interfaces #12631
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akrmn akrmn

Labels
language Language team work
Projects
None yet
Milestone
Daml Interfaces
Development

Successfully merging a pull request may close this issue.

Add scala serializability checks for interfaces digital-asset/daml
2 participants
@cocreature @akrmn