Emit warnings on controller can syntax #11317

cocreature · 2021-10-20T14:51:45Z

We want to deprecate the controller … can syntax in favor of the choice X controller … syntax. To do that we need to catch this in our GHC parser https://github.com/digital-asset/ghc/blob/9fcd347e46790d0d054c347de7d36303426ee173/compiler/parser/Parser.y#L1241 and emit a warning.

This also means we have to update our docs to no longer use that.

The text was updated successfully, but these errors were encountered:

part of #11317 changelog_begin changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

part of #11317 changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

part of #11317

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

Closes #11317 * Add warning for uses of 'controller ... can' syntax * Remove uses of 'controller ... can' syntax * Add test cases for -W{,no-}controller-can * Update docs to reflect 'controller ... can' syntax deprecation changelog_begin * Deprecate 'controller ... can' syntax. * It will be removed in a future version of Daml. * Instead, use 'choice ... with ... controller' syntax. Note that this does not implictly add the controller as an observer, so it must be added explictly as one (or as a signatory). changelog_end

cocreature added language Language team work SDK 2.0 labels Oct 20, 2021

cocreature assigned stefanobaghino-da and unassigned stefanobaghino-da Oct 20, 2021

akrmn self-assigned this Oct 21, 2021

moisesackerman-da pushed a commit that referenced this issue Oct 25, 2021

Add warning for uses of 'controller ... can' syntax

a9d024c

part of #11317 changelog_begin changelog_end

moisesackerman-da pushed a commit that referenced this issue Oct 25, 2021

Remove uses of 'controller ... can' syntax

a698daa

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 25, 2021

Update docs to reflect 'controller ... can' syntax deprecation

c7e94c4

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn mentioned this issue Oct 25, 2021

Deprecate 'controller ... can' syntax #11363

Merged

7 tasks

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Remove uses of 'controller ... can' syntax

e47a60a

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Update docs to reflect 'controller ... can' syntax deprecation

74f8a54

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Remove uses of 'controller ... can' syntax

a5cb191

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Update docs to reflect 'controller ... can' syntax deprecation

35c138e

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Remove uses of 'controller ... can' syntax

ae06b72

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Update docs to reflect 'controller ... can' syntax deprecation

4c94ca5

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Remove uses of 'controller ... can' syntax

62aa2bc

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 26, 2021

Update docs to reflect 'controller ... can' syntax deprecation

ca3388a

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 28, 2021

Remove uses of 'controller ... can' syntax

1e5cc4f

part of #11317

moisesackerman-da pushed a commit that referenced this issue Oct 28, 2021

Update docs to reflect 'controller ... can' syntax deprecation

eb0b36b

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Remove uses of 'controller ... can' syntax

780d3a4

part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Update docs to reflect 'controller ... can' syntax deprecation

57a0551

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Remove uses of 'controller ... can' syntax

2eac143

part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Update docs to reflect 'controller ... can' syntax deprecation

946188e

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Remove uses of 'controller ... can' syntax

9cdd759

part of #11317

akrmn added a commit that referenced this issue Nov 19, 2021

Update docs to reflect 'controller ... can' syntax deprecation

1be9abb

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 29, 2021

Remove uses of 'controller ... can' syntax

1032b11

part of #11317

akrmn added a commit that referenced this issue Nov 29, 2021

Update docs to reflect 'controller ... can' syntax deprecation

b8a6d60

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 29, 2021

Remove uses of 'controller ... can' syntax

dd0e6bb

part of #11317

akrmn added a commit that referenced this issue Nov 29, 2021

Update docs to reflect 'controller ... can' syntax deprecation

b3919ae

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 30, 2021

Remove uses of 'controller ... can' syntax

28eef8d

part of #11317

akrmn added a commit that referenced this issue Nov 30, 2021

Update docs to reflect 'controller ... can' syntax deprecation

5ec02f9

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Nov 30, 2021

Remove uses of 'controller ... can' syntax

0753191

part of #11317

akrmn added a commit that referenced this issue Nov 30, 2021

Update docs to reflect 'controller ... can' syntax deprecation

af4ef25

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Remove uses of 'controller ... can' syntax

1fe8249

part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Update docs to reflect 'controller ... can' syntax deprecation

ef312af

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Remove uses of 'controller ... can' syntax

88dae09

part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Update docs to reflect 'controller ... can' syntax deprecation

7d9d48e

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Remove uses of 'controller ... can' syntax

faee16d

part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Update docs to reflect 'controller ... can' syntax deprecation

704ceb5

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Remove uses of 'controller ... can' syntax

b5d3419

part of #11317

akrmn added a commit that referenced this issue Dec 1, 2021

Update docs to reflect 'controller ... can' syntax deprecation

4f4d9df

Also fixed some literalinclude snippets to use blocks instead of line numbers part of #11317

akrmn closed this as completed in #11363 Dec 1, 2021

akrmn mentioned this issue Aug 16, 2023

Drop support for 'controller..can' syntax #17278

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit warnings on controller can syntax #11317

Emit warnings on controller can syntax #11317

cocreature commented Oct 20, 2021 •

edited

Loading

Emit warnings on controller can syntax #11317

Emit warnings on controller can syntax #11317

Comments

cocreature commented Oct 20, 2021 • edited Loading

cocreature commented Oct 20, 2021 •

edited

Loading