Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interface Fixed Choices #11137

Closed
10 tasks done
sofiafaro-da opened this issue Oct 6, 2021 · 0 comments · Fixed by #11528
Closed
10 tasks done

Interface Fixed Choices #11137

sofiafaro-da opened this issue Oct 6, 2021 · 0 comments · Fixed by #11528
Milestone
Daml Interfaces

Comments

@sofiafaro-da
Copy link
Contributor

sofiafaro-da commented Oct 6, 2021 •
edited
Loading

  • daml-lf protobuf
  • haskell ast
  • haskell typechecker
    • add check that interface fixed choice doesn't collide with template choice
  • haskell conversion
  • ghc parser
  • scala ast
  • scala validation
    • add check that interface fixed choice doesn't collide with template choice
  • speedy
@sofiafaro-da sofiafaro-da added this to the Daml Interfaces milestone Oct 6, 2021
This was referenced Oct 6, 2021
Merged
Merged
sofiafaro-da added a commit that referenced this issue Oct 7, 2021
@sofiafaro-da
interface fixed choices: Haskell AST
684ca52 
Part of #11137

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Oct 7, 2021
Merged
6 tasks
mergify bot pushed a commit that referenced this issue Oct 7, 2021
@sofiafaro-da
interface fixed choices: Haskell AST (#11160)
53c76d4 
* interface fixed choices: Haskell AST

Part of #11137

changelog_begin
changelog_end

* Make intParam strict
sofiafaro-da added a commit that referenced this issue Oct 8, 2021
@sofiafaro-da
interface fixed choices: Haskell Typechecker
4443462 
Part of #11137

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Oct 8, 2021
Merged
6 tasks
sofiafaro-da added a commit that referenced this issue Oct 8, 2021
@sofiafaro-da
interface fixed choices: Haskell Typechecker (#11177)
7e2edbd 
Part of #11137

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Oct 12, 2021
@sofiafaro-da
interface fixed choices: LFConversion support
4e3be0e 
Part of #11137

changelog_begin
changelog_edn
@sofiafaro-da sofiafaro-da mentioned this issue Oct 12, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Oct 12, 2021
@sofiafaro-da
interface fixed choices: LFConversion support
6de8438 
Part of #11137

changelog_begin
changelog_edn
sofiafaro-da added a commit that referenced this issue Oct 12, 2021
@sofiafaro-da
interface fixed choices: LFConversion support
cb1770b 
Part of #11137

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Oct 12, 2021
@sofiafaro-da
interface fixed choices: LFConversion support
7f690ee 
Part of #11137

changelog_begin
changelog_end
mergify bot pushed a commit that referenced this issue Oct 12, 2021
@sofiafaro-da
interface fixed choices: LFConversion support (#11206)
7a02e7c 
* interface fixed choices: LFConversion support

Part of #11137

changelog_begin
changelog_end

* Update experimental primitives name, invoke UExerciseInterface
This was referenced Oct 13, 2021
Merged
Merged
Merged
sofiafaro-da added a commit that referenced this issue Oct 21, 2021
@sofiafaro-da
interfaces: Add fixed choice name collision check
8c8e237 
Add a check that a template cannot have two choices with the same name,
even taking into account all of its "inherited" interface fixed choices.

Part of #11137

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Oct 21, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Oct 21, 2021
@sofiafaro-da
interfaces: Add fixed choice collision check in typechecker (Haskell) (…
ed9dbed 
…#11337)

* interfaces: Add fixed choice name collision check

Add a check that a template cannot have two choices with the same name,
even taking into account all of its "inherited" interface fixed choices.

Part of #11137

changelog_begin
changelog_end

* "Me want" -> "We want"
@sofiafaro-da sofiafaro-da mentioned this issue Oct 22, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 1, 2021
@sofiafaro-da
Check fixed choices in name collision checker
6253be0 
This is a follow up to #11364. This PR checks that the list of inherited
choice names is correct in the type checker, and moves the "fixed choice name
collision" check into the name collision checker using this data.

Haskell side only for now. Part of #11137.

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Nov 1, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 1, 2021
@sofiafaro-da @cocreature
Check fixed choices in name collision checker (#11481)
d8898b8 
* Check fixed choices in name collision checker

This is a follow up to #11364. This PR checks that the list of inherited
choice names is correct in the type checker, and moves the "fixed choice name
collision" check into the name collision checker using this data.

Haskell side only for now. Part of #11137.

changelog_begin
changelog_end

* Update compiler/daml-lf-tools/src/DA/Daml/LF/TypeChecker/Check.hs

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>

Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>
sofiafaro-da added a commit that referenced this issue Nov 2, 2021
@sofiafaro-da
interface: Add inherited choice names in scala AST
5dc406c 
Also checks that they're right. There's no collision checking yet.

Part of #11137.

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Nov 2, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 2, 2021
@sofiafaro-da
interface: Add inherited choice names in scala AST (#11503)
48afb7b 
Also checks that they're right. There's no collision checking yet.

Part of #11137.

changelog_begin
changelog_end
sofiafaro-da added a commit that referenced this issue Nov 3, 2021
@sofiafaro-da
Add choice collisions in scala name collision chk
65dc513 
This brings it in line with the LF spec.
This PR also adds collisions for inherited (interface) choices.
Closes #11137.

changelog_begin
changelog_end
@sofiafaro-da sofiafaro-da mentioned this issue Nov 3, 2021
Merged
7 tasks
sofiafaro-da added a commit that referenced this issue Nov 3, 2021
@sofiafaro-da @remyhaemmerle-da
Add choice collisions in scala name collision checker (#11528)
776790e 
* Add choice collisions in scala name collision chk

This brings it in line with the LF spec.
This PR also adds collisions for inherited (interface) choices.
Closes #11137.

changelog_begin
changelog_end

* scalafmt

* Apply suggestions from code review

Co-authored-by: Remy <remy.haemmerle@daml.com>

Co-authored-by: Remy <remy.haemmerle@daml.com>
@sofiafaro-da sofiafaro-da mentioned this issue Nov 9, 2021
Closed
@remyhaemmerle-da remyhaemmerle-da mentioned this issue Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Daml Interfaces
Development

Successfully merging a pull request may close this issue.

Add choice collisions in scala name collision checker digital-asset/daml
1 participant
@sofiafaro-da