Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate Hikari upgrade on Canton #10420

Open
cocreature opened this issue Jul 27, 2021 · 1 comment
Open

Investigate Hikari upgrade on Canton #10420

cocreature opened this issue Jul 27, 2021 · 1 comment

Comments

@cocreature
Copy link
Contributor

We reverted an upgrade to Hikari 4.x since it caused issues for Canton. While the upgrade is not critical, sticking with an old version forever is also not a great option so we should investigate this and figure out how we can upgrade.
cocreature added a commit that referenced this issue Jul 27, 2021
@cocreature
Revert "Upgrade hikari to latest jdk8 version (#10406)"
585c957 
This reverts commit d88dc71.

This causes some issues for Canton so reverting until we figure that
out. Tracked in #10420

changelog_begin
changelog_end
@cocreature cocreature mentioned this issue Jul 27, 2021
Merged
6 tasks
@oliverse-da
Copy link
Contributor

The conflict is related to canton's use of slick 3.3.3 (latest release, but has not been rereleased since September 2020). The symptoms seem to be caused by different exceptions which no longer map to canton's InternalException the same way.

mergify bot pushed a commit that referenced this issue Jul 27, 2021
@cocreature
Revert "Upgrade hikari to latest jdk8 version (#10406)" (#10421)
1c4ae50 
This reverts commit d88dc71.

This causes some issues for Canton so reverting until we figure that
out. Tracked in #10420

changelog_begin
changelog_end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cocreature @oliverse-da