resources: Only mutate test mock objects inside synchronized blocks. (

#9869) That was silly. CHANGELOG_BEGIN CHANGELOG_END
digital-asset · Jun 1, 2021 · d7c60f5 · d7c60f5
1 parent 3a0b2f9
commit d7c60f5
Showing 1 changed file with 17 additions and 5 deletions.
diff --git a/libs-scala/resources/src/test/suite/scala/com/digitalasset/resources/ResourceOwnerSpec.scala b/libs-scala/resources/src/test/suite/scala/com/digitalasset/resources/ResourceOwnerSpec.scala
@@ -709,10 +709,15 @@ final class ResourceOwnerSpec extends AsyncWordSpec with Matchers {
       val owners = (1 to 10).map(value =>
         new AbstractResourceOwner[TestContext, Int] {
           override def acquire()(implicit context: TestContext): Resource[Int] = {
-            acquireOrder += value
+            acquireOrder.synchronized {
+              acquireOrder += value
+            }
             Resource(Future(value))(v =>
               Future {
-                released += v
+                released.synchronized {
+                  released += v
+                }
+                ()
               }
             )
           }
@@ -747,11 +752,16 @@ final class ResourceOwnerSpec extends AsyncWordSpec with Matchers {
         new AbstractResourceOwner[TestContext, Int] {
           override def acquire()(implicit context: TestContext): Resource[Int] =
             Resource(Future {
-              acquired += value
+              acquired.synchronized {
+                acquired += value
+              }
               value
             })(v =>
               Future {
-                released += v
+                released.synchronized {
+                  released += v
+                }
+                ()
               }
             )
         }
@@ -785,7 +795,9 @@ final class ResourceOwnerSpec extends AsyncWordSpec with Matchers {
           override def acquire()(implicit context: TestContext): Resource[Int] = {
             Resource(Future(value)) { v =>
               Delayed.by((v * 200).milliseconds) {
-                releaseOrder += v
+                releaseOrder.synchronized {
+                  releaseOrder += v
+                }
                 ()
               }
             }