[cleanup] return Result instead of panic-ing in TypeLayoutBuilder #50
+13
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrwg
previously approved these changes
Feb 12, 2022
sblackshear
force-pushed
the
fix_layout_panics
branch
2 times, most recently
from
d736f5d to
924acb4
Compare
|
Had to fix a lint error, re-stamp requested! |
wrwg
previously approved these changes
Feb 15, 2022
|
/land |
No need to panic here, just makes life harder for a caller that made a mistake. Closes: diem#50
bors-diem
force-pushed
the
fix_layout_panics
branch
from
924acb4 to
595b6d0
Compare
villesundell
pushed a commit
to villesundell/move-old
that referenced
this pull request
Apr 26, 2022
sahithiacn
pushed a commit
to sahithiacn/move
that referenced
this pull request
Jan 2, 2023
Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com>
bors-diem
pushed a commit
that referenced
this pull request
Jan 2, 2023
Signed-off-by: sahithiacn <sahithi.kalakonda@accenture.com> Closes: #297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to panic here, just makes life harder for a caller that made a mistake.